Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: Upgrade to Sparkle 2 #7499

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Improve: Upgrade to Sparkle 2 #7499

merged 3 commits into from
Oct 29, 2024

Conversation

rparet
Copy link
Contributor

@rparet rparet commented Oct 24, 2024

Brief overview of PR changes/additions

Move from Sparkle 1.25 to Sparkle 2.6.4 for Mac updates.

Motivation for adding to Mudlet

Stay current with 3rd party dependencies.

Other info (issues closed, discussion etc)

Fixes #6665

Moves sparkle directly into mudlet/mudlet and eliminates the third party dependency.

@rparet rparet requested a review from a team as a code owner October 24, 2024 23:49
@add-deployment-links
Copy link

add-deployment-links bot commented Oct 24, 2024

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@SlySven SlySven added the Hacktoberfest Code & win a T-shirt :) label Oct 25, 2024
@vadi2
Copy link
Member

vadi2 commented Oct 25, 2024

It seems entirely possible to cut out the 3rd party dependency

That would be nice, mixing-cocoa-and-qt is just there as it was a way I found this to work. macOS isn't my main development platform and that was just how I got this to work.

@rparet
Copy link
Contributor Author

rparet commented Oct 27, 2024

Updated this PR with a more direct approach. Removed mixing-cocoa-and-qt and added direct support for Sparkle as an updater.

Also, included DEV_SPARKLE as an environment flag to more easily test updater changes in development. Prior to this, it was more or less hardcoded to ptb/release.

Copy link
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! Let's give it a spin.

@vadi2 vadi2 merged commit b71b29f into Mudlet:development Oct 29, 2024
12 checks passed
@vadi2
Copy link
Member

vadi2 commented Oct 30, 2024

Looks like the packaging step needs more polish, could you look? https://github.com/Mudlet/Mudlet/actions/runs/11596182977/job/32286624135?pr=7349#step:27:161 @rparet

@rparet
Copy link
Contributor Author

rparet commented Oct 30, 2024

on it. really odd that it built cleanly on the branch. I'll have an update shortly.

@rparet
Copy link
Contributor Author

rparet commented Oct 30, 2024

@vadi2 Mudlet/installers#119 - note that because this involves code signing, I couldn't really test this as thoroughly as I would normally like. Apologies in advance if this takes more than one pass.

@vadi2
Copy link
Member

vadi2 commented Oct 30, 2024

That's okay! Sometimes these things don't lend themselves well to local testing as you say.

@vadi2
Copy link
Member

vadi2 commented Oct 30, 2024

Looks like it worked great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Code & win a T-shirt :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Sparkle 2.x
3 participants