-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve: Upgrade to Sparkle 2 #7499
Conversation
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
That would be nice, |
Updated this PR with a more direct approach. Removed Also, included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid! Let's give it a spin.
Looks like the packaging step needs more polish, could you look? https://github.com/Mudlet/Mudlet/actions/runs/11596182977/job/32286624135?pr=7349#step:27:161 @rparet |
on it. really odd that it built cleanly on the branch. I'll have an update shortly. |
@vadi2 Mudlet/installers#119 - note that because this involves code signing, I couldn't really test this as thoroughly as I would normally like. Apologies in advance if this takes more than one pass. |
That's okay! Sometimes these things don't lend themselves well to local testing as you say. |
Looks like it worked great 👍 |
Brief overview of PR changes/additions
Move from Sparkle 1.25 to Sparkle 2.6.4 for Mac updates.
Motivation for adding to Mudlet
Stay current with 3rd party dependencies.
Other info (issues closed, discussion etc)
Fixes #6665
Moves sparkle directly into mudlet/mudlet and eliminates the third party dependency.