Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dispatch job on push:tag + Remaining steps on either tags or dispatch
Latest runs observations. - Passed for server, join, admin-dash, public-dash. - Failed for admin-dash, public-dash. - Workflow dispatch occurred twice since the server build job was a dependency for dispatch job and we removed ref_type == tag check. - To prevent dispatch occurring twice, need to add ref_type check to dispatch job in server workflow. - This caused dispatch to be triggered even for push:branch event on server. - But this doesn’t update version tag so even with dispatch, the dashboard workflows should have used the current non-updated server tag. - But during testing I immediately also create a new release with a new tag, and the reusable workflow fetches tags from GitHub REST API. - So even though push:branch event didn’t update server tag, my manual UI tag creation already updated it. - This caused the dispatch events that were triggered on push:branch in dashboards to pick up the latest UI tag. - But this fails since this image was never pushed since we only push on push:tags event. - In parallel, server workflow for push:tags had already started running as well and this did push the server image with latest new tag created through UI. - However, for workflow dispatch events as well the remaining steps were skipped since workflow_dispatch also has a ref_type: branch. - Hence need to add OR condition that checks for both ref_type: tags (in case of push:tags event) as well as event_name: workflow_dispatch for dashboard workflows triggered on server push:tag only.
- Loading branch information