Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct case for emandate property in Gateway Account #15

Closed
wants to merge 3 commits into from

Conversation

malles
Copy link

@malles malles commented Nov 9, 2024

While setting up a transactions gateway data I got confused by the addEmanDate() method name and added the date of the mandate to that field.
However that field refers to the property emandate as per the docs

emandate
string
For SEPA Direct Debit direct orders (required), the unique emandate identifier (for your own administration).

I have edited the class to reflect the correct property name.
Due to the private visibility of the property, and PHP's case-insensitive function names this should not cause any problems in backward compatibility.

@vinodsowdagar
Copy link
Member

@malles ,

Indeed right now it looks like the Emandate is a 'date' but it's not. Thank you for your PR! We're going to add it in the next release.

@danielcivit
Copy link
Member

Thanks for your contribution @malles

Closing this PR, since the changes are included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants