Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luck automation #421

Closed
wants to merge 8 commits into from
Closed

luck automation #421

wants to merge 8 commits into from

Conversation

bb46003
Copy link
Contributor

@bb46003 bb46003 commented May 22, 2024

i add funcionality to spend luck when reroll for character or robot type of actor, when you re roll you got pop up window how many od selected dice you want to re roll using luck and how namy without spending luck, when DC i rerolled 1 luck is spedn for every 3 DC, ef 3Dc cost 1 luck, but 4-6 cost 2 luck point, and so on

BartlomiejBielecki and others added 2 commits May 22, 2024 13:39
i add funcionality to spend luck when reroll for character or robot type of actor, when you re roll you got pop up window how many od selected dice you want to re roll using luck and how namy without spending luck, when DC i rerolled 1 luck is spedn for every 3 DC
i18n/en.yaml Outdated Show resolved Hide resolved
i18n/en.yaml Outdated Show resolved Hide resolved
Copy link
Owner

@Muttley Muttley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See requested changes in comments before this can be merged.

@bb46003
Copy link
Contributor Author

bb46003 commented May 25, 2024

See requested changes in comments before this can be merged.

Thanks for all comments, I’ll fix all issues and once again thanks for showing me how to better coding

BartlomiejBielecki added 2 commits May 26, 2024 00:42
additionaly I add information to chat about number of re rolled dice and spedn luck points
…ation

confict folve and pull to current system version
@bb46003
Copy link
Contributor Author

bb46003 commented May 25, 2024

all rqeuest changes are done, as well I add favore text to chat telling how many dice are are reroll, how may points we spend and how many dice are re roll for free

@bb46003 bb46003 requested a review from Muttley May 25, 2024 22:53
BartlomiejBielecki added 3 commits May 26, 2024 00:56
i just realize that i delet wrong line
avoid flavor text for gm, fix re rolling null for gm
Copy link
Contributor Author

@bb46003 bb46003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All request changes are made

@Muttley
Copy link
Owner

Muttley commented Jun 16, 2024

After having played with this a bit, from a usability point of view I'm afraid this isn't as useable as I'd like it to be.

It would be better to have seperate "Reroll" and "Reroll with Luck" buttons on the roll result chat message, so it can be entirely avoided when not needed, and instead of simple number input a slider would be better that adjusts the balance between luck and normal re-rolls.

The min/max of the slider should be linked to the amount of dice selected for re-roll and the amount of luck points remaining, and default to 1.

Does that make sense?

@bb46003
Copy link
Contributor Author

bb46003 commented Jun 16, 2024

for me it realy depends how you play, RAW only d20 can be re rolled free, so only there it is needed, on CD rolls alway you need to spend luck (AFAIK) but system should not force yoy to re roll with luck, from interface point of view slider can by an option, can you do simple sketch ( even in paint ) to show me your vision ?

@Muttley Muttley closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants