Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npc localization #439

Closed
wants to merge 2 commits into from
Closed

Npc localization #439

wants to merge 2 commits into from

Conversation

bb46003
Copy link
Contributor

@bb46003 bb46003 commented Jun 4, 2024

I add localization option for skill list on NPC and change S.P.E.C.I.A.L to localize on NPC

Muttley and others added 2 commits June 1, 2024 21:39
add option to localize by system npc skills and S.P.E.C.I.A.L in npc sheet
@Muttley
Copy link
Owner

Muttley commented Jun 16, 2024

You seem to have included two seperate issues here. Please only address one issue per merge request, and always create an issue for them first.

The first is a genuine issue, but you have resolved it in a slightly odd way:

			case "skill": {
				const localizeName = fallout.utils.getLocalizedSkillName(item);
				return `${localizeName}`;
			}

This has unecessary string manipulation and would be better implemented as just:

			case "skill": {
				return fallout.utils.getLocalizedSkillName(item);
			}

I also prefer it if case statements can be kept in alphabetical order wherever possible.

I've raised issue #453 for this and resolved it in the preferred way.

The second issue will have knock-on effects for languages that still use the iconic S.P.E.C.I.A.L. acronym even if it makes no sense in their own language (French for example), so I'm afraid I will have to reject that one.

@Muttley Muttley closed this Jun 16, 2024
@bb46003
Copy link
Contributor Author

bb46003 commented Jun 16, 2024

About second point I just want to unified npc with character sheet. On character sheet (normal and robota) you not always have special as attributes, it is always capital first letter of attribute name, eg in Polish we have SPWCIZS and it is on character sheet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants