-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Prepare release of version 7.1.0 #1238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree with version number, since to support PHP 8.3, we don't need to drop support for PHP 7.3, there are no other breaking changes, and it's not merely a bugfix release. The 8.0 release is when we drop PHP 7.3 (or make some other non-backwards-compatible change, which might not actually involve dropping PHP 7.3 as planned).
However, as this is on the main release line, shouldn't the 'Added' and 'Changed' sections be cleared for the next x.y.z
release? Won't 8.0.0 include everything in 7.1.0 by definition - I mean, if the next major or minor release is indeed 8.0.0, there will never be a 7.2.0, only ever perpahs a 7.1.1 - ?
I checked the 'Steps to release a new version' and indeed the branch-alias
does not need changing for a minor release.
I'm confused … :-) Are you referring to the alias in the (Also, I've noticed that in our release checklist, the "next version" would need a look into the future. I think it's our best guess then.) |
Sorry, my waffliness may have muddied what I was saying. I meant the changelog should not have the changes for 7.1.0 duplicated into the section for the next (x.y.z) release, because the next main (x.y.z) release will include the 7.1.0 changes (by definition according to semver, if I understand correctly).
Yes, that's what I was trying to say. No changes to |
e22c713
to
b0ed418
Compare
Yes, I agree. This also is what we've been doing so far. Oh, I see that I indeed duplicated things in this PR. Thanks for catching this! I've repushed now. |
No description provided.