[TASK] Add Preg::matchAll to wrap preg_match_all with error handling
#1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will likely have a merge conflict with #1327. |
JakeQZ
force-pushed
the
task/preg-match-all-error-handler
branch
2 times, most recently
from
ef5dc1a to
4dc2e7a
Compare
oliverklee
approved these changes
Sep 20, 2024
|
This now indeed needs a rebase. |
JakeQZ
force-pushed
the
task/preg-match-all-error-handler
branch
from
4dc2e7a to
ee5a189
Compare
This completes the set of wrappers for `preg_` functions that might unexpectedly fail, and which are used in the codebase.
JakeQZ
force-pushed
the
task/preg-match-all-error-handler
branch
from
ee5a189 to
184acb8
Compare
oliverklee
changed the title
Preg::matchAll to wrap preg_match_all with error handling
oliverklee
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the set of wrappers for
preg_functions that might unexpectedly fail, and which are used in the codebase.