Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Use PHPUnit 9.x with PHP 7.3+ #930

Merged
merged 7 commits into from
Nov 22, 2020
Merged

[TASK] Use PHPUnit 9.x with PHP 7.3+ #930

merged 7 commits into from
Nov 22, 2020

Commits on Nov 22, 2020

  1. [TASK] Use PHPUnit 9.x with PHP 7.3+ 

    This is required to be able to test against PHP 8.  However, PHPUnit 9.x
requires PHP 7.3, so a different version of PHPUnit is required for different
testing environments.

The main change here is a step in the GitHub Action to conditionally update
PHPUnit via PHIVE for PHP >=7.3.  PHIVE does not yet have the ability for
conditional installs (see
phar-io/phive#295 (comment)) so the
script must check the PHP version before running the update.

PHIVE has also been added to the tools (self-referencing) as it is not available
by default to GitHub Actions.

Note: There are warnings from PHPUnit 9.x about use of deprecated `assert`
methods (which will be removed in PHPUnit 10.x).  However, these don't cause the
tests to fail, and the replacement methods are not available in PHPUnit 7.x
which is still required to test against PHP 7.1 and 7.2.

Part of #925/#926.
    @JakeQZ
    JakeQZ committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    3fbc41d View commit details
    Browse the repository at this point in the history

  2. Use --trust-gpg-keys and --no-progress on PHIVE command line.

    @JakeQZ
    JakeQZ committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    0bb6617 View commit details
    Browse the repository at this point in the history

  3. Remove --trust-gpg-keys PHIVE command line option.

    @JakeQZ
    JakeQZ committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    6eb372e View commit details
    Browse the repository at this point in the history

  4. Move PHIVE command line option before command.

    @JakeQZ
    JakeQZ committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    23efe2f View commit details
    Browse the repository at this point in the history

  5. Update PHIVE to version 0.14.4.

    @JakeQZ
    JakeQZ committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    999c536 View commit details
    Browse the repository at this point in the history

  6. Only call PHPUnit Constraint constructor if it exists.

    @JakeQZ
    JakeQZ committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    0205609 View commit details
    Browse the repository at this point in the history

  7. Change constructor access level to public for PHP 7.1 compatibility. 

    Only since PHP 7.2 can the access level in a child class be made more
restrictive.  See [PHP bug #61970](https://bugs.php.net/bug.php?id=61970).
    @JakeQZ
    JakeQZ committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    8a52bb5 View commit details
    Browse the repository at this point in the history