Filter out warning when connecting (#1369)

src/main/java/org/myrobotlab/arduino/virtual/MrlComm.java

@@ -1018,4 +1018,9 @@ public void neoPixelSetBrightness(Integer deviceId, Integer brightness) {
 
   }
 
+  public boolean isConnecting() {
+    // TODO Auto-generated method stub
+    return false;
+  }
+
 }

src/main/java/org/myrobotlab/service/Arduino.java

@@ -129,6 +129,12 @@ public static class I2CDeviceMap {
   boolean boardInfoEnabled = true;
 
   private long boardInfoRequestTs;
+
+  /**
+   * connecting is true while the arduino is in the process of connecting
+   * to a port
+   */
+  protected boolean connecting = false;
 
   @Deprecated /*
                * should develop a MrlSerial on Arduinos and
@@ -535,7 +541,7 @@ public VirtualArduino getVirtual() {
    */
   @Override
   public void connect(String port, int rate, int databits, int stopbits, int parity) {
-
+    connecting = true;
     if (port == null) {
       warn("%s attempted to connect with a null port", getName());
       return;
@@ -596,6 +602,7 @@ public void connect(String port, int rate, int databits, int stopbits, int parit
         sleep(30);
       }
 
+      connecting = false;
       log.info("waited {} ms for Arduino {} to say hello", System.currentTimeMillis() - startBoardRequestTs, getName());
 
       // we might be connected now
@@ -1341,6 +1348,10 @@ public boolean isAttached(Attachable service) {
   public boolean isAttached(String name) {
     return deviceList.containsKey(name);
   }
+
+  public boolean isConnecting() {
+    return connecting;
+  }
 
   @Override
   public boolean isConnected() {
@@ -1595,13 +1606,16 @@ public BoardInfo publishBoardInfo(Integer version/* byte */,
 
     boardInfo = new BoardInfo(version, boardTypeId, boardTypeName, microsPerLoop, sram, activePins, arrayToDeviceSummary(deviceSummary), boardInfoRequestTs);
 
+    // connected now
+    connecting = false;
+
     boardInfoRequestTs = System.currentTimeMillis();
 
     log.debug("Version return by Arduino: {}", boardInfo.getVersion());
     log.debug("Board type currently set: {} => {}", boardTypeId, boardTypeName);
 
     if (lastBoardInfo == null || !lastBoardInfo.getBoardTypeName().equals(board)) {
-      log.warn("setting board to type {}", board);
+      log.info("setting board to type {}", boardInfo.getBoardTypeName());
       this.board = boardInfo.getBoardTypeName();
       // we don't invoke, because
       // it might get into a race condition

src/main/java/org/myrobotlab/service/interfaces/MrlCommPublisher.java

@@ -41,7 +41,9 @@ public BoardInfo publishBoardInfo(Integer version/* byte */,
   public String publishMRLCommError(String errorMsg);
 
   public PinData[] publishPinArray(int[] data);
-
+
+  public boolean isConnecting();
+
   public String getName();
 
   public Integer publishUltrasonicSensorData(Integer deviceId, Integer echoTime);

src/main/resources/resource/Arduino/MrlComm/MrlNeopixel.cpp

@@ -176,6 +176,8 @@ void MrlNeopixel::setAnimation(byte animation, byte red, byte green, byte blue,
 {
   animationIndex = animation;
   x = 0;
+  y = 0;
+  z = 0;
   color = Adafruit_NeoPixel::Color(red, green, blue, white);
   wait = wait_ms;
   if (animation == 0)

src/main/resources/resource/Arduino/generate/Msg.java.template

@@ -234,7 +234,9 @@ public class %javaClass% {
             msgSize = 0;
             Arrays.fill(ioCmd, 0); // FIXME - optimize - remove
             // warn(String.format("Arduino->MRL error - bad magic number %d - %d rx errors", newByte, ++errorServiceToHardwareRxCnt));
-            log.warn("Arduino->MRL error - bad magic number {} - {} rx errors", newByte, ++errorServiceToHardwareRxCnt);
+            if (!arduino.isConnecting()){
+              log.warn("Arduino->MRL error - bad magic number {} - {} rx errors", newByte, ++errorServiceToHardwareRxCnt);
+            }
           }
           continue;
         } else if (byteCount.get() == 2) {
@@ -267,7 +269,10 @@ public class %javaClass% {
           } 
 
           if (!clearToSend) {
-            log.warn("NOT CLEAR TO SEND! resetting parser!");
+            if (!arduino.isConnecting()) {
+              // we're connecting, so we're going to ignore the message.
+              log.warn("NOT CLEAR TO SEND! resetting parser!");
+            }
             // We opened the port, and we got some data that isn't a Begin message.
             // so, I think we need to reset the parser and continue processing bytes...
             // there will be errors until the next magic byte is seen.
@@ -482,7 +487,7 @@ public class %javaClass% {
   }
 
   public void waitForAck(){
-    if (!ackEnabled) {
+    if (!ackEnabled || serial == null || !serial.isConnected()) {
       return;
     }
     // if there's a pending message, we need to wait for the ack to be received.

src/test/java/org/myrobotlab/arduino/MrlCommDirectTest.java

@@ -366,4 +366,10 @@ public Object invoke(String method, Object... params) {
     return null;
   }
 
+  @Override
+  public boolean isConnecting() {
+    // TODO Auto-generated method stub
+    return false;
+  }
+
 }

src/test/java/org/myrobotlab/service/VirtualArduinoTest.java

@@ -223,4 +223,10 @@ public Object invoke(String method, Object... params) {
     return null;
   }
 
+  @Override
+  public boolean isConnecting() {
+    // TODO Auto-generated method stub
+    return false;
+  }
+
 }