This repository has been archived by the owner on Apr 25, 2019. It is now read-only.
Handle address provider unsupported currencies when creating a new order #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TE_CURRENCY The current implementation for `FixerAdapter#rate_for`, which inherits from `FiatAdapter#rate_for`, was calling for `super` but wasn't honoring the result from `super` when the given `currency_code` was the `CROSS_RATE_CURRENCY` and would raise a `CurrencyNotSupported` error instead of using the `return 1` from the `CROSS_RATE_CURRENCY` comparison.
When trying to create a `#new_order` for a Gateway with an `AddressProvider` that doesn't support the given currency we now convert that currency to one the AddressProvider can handle using the `FixerAdapter` rates that apply.
Address providers are expected to define this method as an Enumerable with valid currency codes. e.g. 'EUR', 'USD'. This method is used to determine if a the currency should be converted to one the address provider supports when creating an order.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to create a
#new_orderfor a Gateway with anAddressProviderthat doesn't support the given currency we now convert that currency to
one the AddressProvider can handle using the
FixerAdapterrates that apply.