Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subtract to MultiHash #605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add subtract to MultiHash #605

wants to merge 1 commit into from

Conversation

lxfind
Copy link

@lxfind lxfind commented Jun 8, 2023

Add a way to subtract an entire mutihash from a multihash.
Does this even make sense?

@lxfind lxfind requested review from jonas-lj, joyqvq and benr-ml June 8, 2023 05:33
benr-ml
benr-ml reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@benr-ml benr-ml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense. Please add a couple of sanity checks in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benr-ml benr-ml benr-ml left review comments

@jonas-lj jonas-lj Awaiting requested review from jonas-lj

@joyqvq joyqvq Awaiting requested review from joyqvq

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lxfind @benr-ml