Merkle trees first commit #612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benr-ml
reviewed
Jun 21, 2023
benr-ml
reviewed
Jul 24, 2023
| //! # use fastcrypto::hash::Sha256; | ||
| //! # use fastcrypto_data::merkle_tree::*; | ||
| //! let elements = [[1u8], [2u8], [3u8]]; | ||
| //! let mut tree = MerkleTree::<32, Sha256, [u8; 1]>::new(); |
| } | ||
|
|
||
| impl<const DIGEST_LENGTH: usize, H: HashFunction<DIGEST_LENGTH>, T: AsRef<[u8]>> | ||
| MerkleTree<DIGEST_LENGTH, H, T> |
There was a problem hiding this comment.
pls merge with the impl of this struct above
| /// | ||
| /// To avoid second-preimage attacks, a 0x00 byte is prepended to the hash data for leaf nodes (see | ||
| /// [LeafHasher]), and 0x01 is prepended when computing internal node hashes (see [InternalNodeHasher]). | ||
| pub struct MerkleTree<const DIGEST_LENGTH: usize, H: HashFunction<DIGEST_LENGTH>, T: AsRef<[u8]>> { |
There was a problem hiding this comment.
why do we need T here? can we instead have generic insert()?
| /// | ||
| /// To avoid second-preimage attacks, a 0x00 byte is prepended to the hash data for leaf nodes (see | ||
| /// [LeafHasher]), and 0x01 is prepended when computing internal node hashes (see [InternalNodeHasher]). | ||
| pub struct MerkleTree<const DIGEST_LENGTH: usize, H: HashFunction<DIGEST_LENGTH>, T: AsRef<[u8]>> { |
There was a problem hiding this comment.
Maybe instead of requiring AsRef, let's require trait Hashable or just Serialize
(AsRef requires using OnceCell in some cases, which we better avoid unless have to).
| MerkleTree<DIGEST_LENGTH, H, T> | ||
| { | ||
| /// Hash an element using the hash function used for this tree. | ||
| pub fn hash(element: &T) -> [u8; DIGEST_LENGTH] { |
| //! assert!(verifier.verify(index, &elements[index], &proof)); | ||
| //! ``` | ||
|
|
||
| use std::borrow::Borrow; |
There was a problem hiding this comment.
What is the use case for this data structure? there are many variants of merkle trees, e.g., key-value, with deletions, etc.
Also, what is the expected number of objects, and the expected insertion/deletion pattern?
kchalkias
reviewed
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.