Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mvr graphql e2e tests #20408

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Add mvr graphql e2e tests #20408

merged 7 commits into from
Jan 22, 2025

Conversation

wlmyng
Copy link
Contributor

@wlmyng wlmyng commented Nov 23, 2024

Description

With changes to transactional test runner, we can now run flavors of indexer and graphql through it

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@wlmyng wlmyng requested a review from ronny-mysten as a code owner November 23, 2024 16:56
Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 9:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 9:59pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 9:59pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 9:59pm

@wlmyng wlmyng temporarily deployed to sui-typescript-aws-kms-test-env November 23, 2024 16:56 — with GitHub Actions Inactive
@wlmyng wlmyng force-pushed the test-runner-configurable-adapter branch from 11849ed to c59991c Compare December 9, 2024 17:59
Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit!

Comment on lines 71 to 73
// In another crate like `sui-mvr-graphql-e2e-tests`, this would be the place to translate
// from `offchain_config` to something compatible with the indexer and graphql flavor of
// choice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this comment needs updating since we are now in sui-mvr-graphql-e2e-tests!

Base automatically changed from test-runner-configurable-adapter to main December 10, 2024 21:35
@wlmyng wlmyng force-pushed the sui-mvr-graphql-e2e-tests branch from 7cfd6f8 to 39fd1e1 Compare December 11, 2024 00:41
@wlmyng wlmyng temporarily deployed to sui-typescript-aws-kms-test-env December 11, 2024 00:41 — with GitHub Actions Inactive
@wlmyng wlmyng force-pushed the sui-mvr-graphql-e2e-tests branch from 39fd1e1 to 6d90215 Compare January 22, 2025 21:58
@wlmyng wlmyng temporarily deployed to sui-typescript-aws-kms-test-env January 22, 2025 21:58 — with GitHub Actions Inactive
@wlmyng wlmyng merged commit e8d1af1 into main Jan 22, 2025
50 of 51 checks passed
@wlmyng wlmyng deleted the sui-mvr-graphql-e2e-tests branch January 22, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants