Skip to content

Commit

Permalink
Addresses a11y labels issue #1609
Browse files Browse the repository at this point in the history
  • Loading branch information
Dan Allard committed Jan 31, 2025
1 parent bfbef53 commit 08e337c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
2 changes: 2 additions & 0 deletions src/components/TimelineItemList.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@
name="search"
autocomplete="off"
placeholder="Filter {typeName} types"
aria-label="Filter {typeName} types"
/>

<div class="filter-buttons">
<button
class="st-button secondary menu-button"
Expand Down
14 changes: 10 additions & 4 deletions src/components/activity/ActivityDirectivesTablePanel.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
ValueGetterParams,
} from 'ag-grid-community';
import { debounce } from 'lodash-es';
import { get } from 'svelte/store';
import { InvalidDate } from '../../constants/time';
import { activityDirectivesMap, selectActivity, selectedActivityDirectiveId } from '../../stores/activities';
import { activityErrorRollupsMap } from '../../stores/errors';
Expand All @@ -20,8 +21,10 @@
import type { ActivityDirective } from '../../types/activity';
import type { User } from '../../types/app';
import type { AutoSizeColumns, ViewGridSection, ViewTable } from '../../types/view';
import effects from '../../utilities/effects';
import { filterEmpty } from '../../utilities/generic';
import { formatDate, getUnixEpochTimeFromInterval } from '../../utilities/time';
import { getTimeRangeAroundTime } from '../../utilities/timeline';
import { tooltip } from '../../utilities/tooltip';
import GridMenu from '../menus/GridMenu.svelte';
import DataGrid from '../ui/DataGrid/DataGrid.svelte';
Expand All @@ -30,9 +33,6 @@
import Panel from '../ui/Panel.svelte';
import ActivityDirectivesTable from './ActivityDirectivesTable.svelte';
import ActivityTableMenu from './ActivityTableMenu.svelte';
import { get } from 'svelte/store';
import { getTimeRangeAroundTime } from '../../utilities/timeline';
import effects from '../../utilities/effects';
export let gridSection: ViewGridSection;
export let user: User | null;
Expand Down Expand Up @@ -390,7 +390,13 @@
<svelte:fragment slot="header">
<GridMenu {gridSection} title="Activity Directives Table" />
<div class="table-menu">
<input type="search" bind:value={filterExpression} placeholder="Filter Activity Directives" class="st-input" />
<input
type="search"
bind:value={filterExpression}
placeholder="Filter Activity Directives"
aria-label="Filter Activity Directives"
class="st-input"
/>
<div class="size-actions">
<button
class="st-button secondary"
Expand Down

0 comments on commit 08e337c

Please sign in to comment.