Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses a11y labels error issue #1609 #1611

Merged
merged 1 commit into from
Feb 3, 2025
+12 −4
Merged

Addresses a11y labels error issue #1609 #1611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/TimelineItemList.svelte
View file
Original file line number Diff line number Diff line change
@@ -149,7 +149,9 @@
name="search"
autocomplete="off"
placeholder="Filter {typeName} types"
aria-label="Filter {typeName} types"
/>

<div class="filter-buttons">
<button
class="st-button secondary menu-button"
14 changes: 10 additions & 4 deletions src/components/activity/ActivityDirectivesTablePanel.svelte
View file
Original file line number Diff line number Diff line change
@@ -11,6 +11,7 @@
ValueGetterParams,
} from 'ag-grid-community';
import { debounce } from 'lodash-es';
import { get } from 'svelte/store';
import { InvalidDate } from '../../constants/time';
import { activityDirectivesMap, selectActivity, selectedActivityDirectiveId } from '../../stores/activities';
import { activityErrorRollupsMap } from '../../stores/errors';
@@ -20,8 +21,10 @@
import type { ActivityDirective } from '../../types/activity';
import type { User } from '../../types/app';
import type { AutoSizeColumns, ViewGridSection, ViewTable } from '../../types/view';
import effects from '../../utilities/effects';
import { filterEmpty } from '../../utilities/generic';
import { formatDate, getUnixEpochTimeFromInterval } from '../../utilities/time';
import { getTimeRangeAroundTime } from '../../utilities/timeline';
import { tooltip } from '../../utilities/tooltip';
import GridMenu from '../menus/GridMenu.svelte';
import DataGrid from '../ui/DataGrid/DataGrid.svelte';
@@ -30,9 +33,6 @@
import Panel from '../ui/Panel.svelte';
import ActivityDirectivesTable from './ActivityDirectivesTable.svelte';
import ActivityTableMenu from './ActivityTableMenu.svelte';
import { get } from 'svelte/store';
import { getTimeRangeAroundTime } from '../../utilities/timeline';
import effects from '../../utilities/effects';

export let gridSection: ViewGridSection;
export let user: User | null;
@@ -390,7 +390,13 @@
<svelte:fragment slot="header">
<GridMenu {gridSection} title="Activity Directives Table" />
<div class="table-menu">
<input type="search" bind:value={filterExpression} placeholder="Filter Activity Directives" class="st-input" />
<input
type="search"
bind:value={filterExpression}
placeholder="Filter Activity Directives"
aria-label="Filter Activity Directives"
class="st-input"
/>
<div class="size-actions">
<button
class="st-button secondary"

Unchanged files with check annotations Beta

View file
e2e-tests/fixtures/Models.ts
await expect(filterIcon).toBeVisible();
await filterIcon.click();
await this.page.locator('.ag-popup').getByRole('textbox', { name: 'Filter Value' }).first().fill(modelName);
await expect(this.table.getByRole('row', { name: modelName })).toBeVisible();

Check failure on line 110 in e2e-tests/fixtures/Models.ts

GitHub Actions / e2e-test

[e2e tests] › tests/model.test.ts:143:3 › Model › Should successfully save the model changes 

  1) [e2e tests] › tests/model.test.ts:143:3 › Model › Should successfully save the model changes ──
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: getByRole('treegrid').getByRole('row', { name: 'partial_jade_gopher' })
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for getByRole('treegrid').getByRole('row', { name: 'partial_jade_gopher' })


       at fixtures/Models.ts:110

      108 |     await filterIcon.click();
      109 |     await this.page.locator('.ag-popup').getByRole('textbox', { name: 'Filter Value' }).first().fill(modelName);
    > 110 |     await expect(this.table.getByRole('row', { name: modelName })).toBeVisible();
          |                                                                    ^
      111 |     await this.page.keyboard.press('Escape');
      112 |   }
      113 |
        at Models.filterTable (/home/runner/work/***-ui/***-ui/e2e-tests/fixtures/Models.ts:110:68)
        at Models.deleteModel (/home/runner/work/***-ui/***-ui/e2e-tests/fixtures/Models.ts:57:5)
        at /home/runner/work/***-ui/***-ui/e2e-tests/tests/model.test.ts:62:3
await this.page.keyboard.press('Escape');
}
View file
e2e-tests/tests/plan-activity-presets.test.ts
let schedulingConditions: SchedulingConditions;
let schedulingGoals: SchedulingGoals;
test.beforeAll(async ({ baseURL, browser }) => {

Check failure on line 18 in e2e-tests/tests/plan-activity-presets.test.ts

GitHub Actions / e2e-test

[e2e tests] › tests/plan-activity-presets.test.ts:73:3 › Plan Activity Presets › Setting a preset to a directive should update the parameter values 

  2) [e2e tests] › tests/plan-activity-presets.test.ts:73:3 › Plan Activity Presets › Setting a preset to a directive should update the parameter values 
    "beforeAll" hook timeout of 30000ms exceeded.

      16 | let schedulingGoals: SchedulingGoals;
      17 |
    > 18 | test.beforeAll(async ({ baseURL, browser }) => {
         |      ^
      19 |   context = await browser.newContext();
      20 |   page = await context.newPage();
      21 |
        at /home/runner/work/***-ui/***-ui/e2e-tests/tests/plan-activity-presets.test.ts:18:6
context = await browser.newContext();
page = await context.newPage();
View file
e2e-tests/fixtures/Plan.ts
}
async fillActivityPresetName(presetName: string) {
await this.panelActivityForm.getByRole('combobox', { name: 'None' }).click();

Check failure on line 252 in e2e-tests/fixtures/Plan.ts

GitHub Actions / e2e-test

[e2e tests] › tests/plan-activity-presets.test.ts:73:3 › Plan Activity Presets › Setting a preset to a directive should update the parameter values 

  2) [e2e tests] › tests/plan-activity-presets.test.ts:73:3 › Plan Activity Presets › Setting a preset to a directive should update the parameter values 
    Error: locator.click: Target page, context or browser has been closed
    Call log:
      - waiting for locator('[data-component-name="ActivityFormPanel"]').getByRole('combobox', { name: 'None' })


       at fixtures/Plan.ts:252

      250 |
      251 |   async fillActivityPresetName(presetName: string) {
    > 252 |     await this.panelActivityForm.getByRole('combobox', { name: 'None' }).click();
          |                                                                          ^
      253 |     await this.panelActivityForm.locator('.dropdown-header').waitFor({ state: 'attached' });
      254 |     await this.panelActivityForm.getByPlaceholder('Enter preset name').click();
      255 |     await this.panelActivityForm.getByPlaceholder('Enter preset name').fill(presetName);
        at Plan.fillActivityPresetName (/home/runner/work/***-ui/***-ui/e2e-tests/fixtures/Plan.ts:252:74)
        at /home/runner/work/***-ui/***-ui/e2e-tests/tests/plan-activity-presets.test.ts:49:14
await this.panelActivityForm.locator('.dropdown-header').waitFor({ state: 'attached' });
await this.panelActivityForm.getByPlaceholder('Enter preset name').click();
await this.panelActivityForm.getByPlaceholder('Enter preset name').fill(presetName);