Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SeqJson Schema v1.3.1 #1600

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Update SeqJson Schema v1.3.1 #1600

merged 2 commits into from
Feb 12, 2025

Conversation

goetzrrGit
Copy link
Contributor

@goetzrrGit goetzrrGit commented Nov 11, 2024 •
edited
Loading

Description

Added immediate_activate immediate_load notes and block time to the seqJson schema. The sequencing server is not using that as the Sequence eDSL has been phased out with SeqN.

This is to address NASA-AMMOS/aerie-ui#1527

Verification

Update the e2e snapshot and test

@goetzrrGit goetzrrGit added the sequencing Anything related to the sequencing domain label Nov 11, 2024
@goetzrrGit goetzrrGit self-assigned this Nov 11, 2024
@goetzrrGit goetzrrGit requested a review from a team as a code owner November 11, 2024 18:51
@goetzrrGit goetzrrGit force-pushed the feature/rtc_activate_load branch from 59b8d5b to 351bfd1 Compare December 10, 2024 21:16
@dandelany dandelany mentioned this pull request Dec 20, 2024
Open
@goetzrrGit goetzrrGit changed the title Update SeqJson Schema v1.1.0 Update SeqJson Schema v1.2.0 Jan 3, 2025
@goetzrrGit goetzrrGit force-pushed the feature/rtc_activate_load branch from 351bfd1 to 60b6bce Compare January 3, 2025 16:02
@goetzrrGit goetzrrGit force-pushed the feature/rtc_activate_load branch from 60b6bce to f0edc70 Compare February 11, 2025 22:25
@goetzrrGit goetzrrGit changed the title Update SeqJson Schema v1.2.0 Update SeqJson Schema v1.3.1 Feb 11, 2025
dandelany
dandelany reviewed Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goetzrrGit - just one small comment, lmk if you wanna discuss.

@goetzrrGit goetzrrGit force-pushed the feature/rtc_activate_load branch from f0edc70 to 7e7316f Compare February 12, 2025 18:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@goetzrrGit goetzrrGit requested a review from dandelany February 12, 2025 19:24
cohansen
cohansen approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dandelany
dandelany approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🚀

@dandelany dandelany merged commit 532fcda into develop Feb 12, 2025
11 checks passed
@dandelany dandelany deleted the feature/rtc_activate_load branch February 12, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandelany dandelany dandelany approved these changes

@cohansen cohansen cohansen approved these changes

@joswig joswig Awaiting requested review from joswig

Assignees

@goetzrrGit goetzrrGit

Labels
sequencing Anything related to the sequencing domain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goetzrrGit @dandelany @cohansen