-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Procedural constraints annotation processor + build logic #1611
base: develop
Are you sure you want to change the base?
Conversation
This PR is currently orphaned, pair programming hosted by @mattdailis prior to handoff. This PR has compiled a constraint w/o arguments, so it's potentially close. @JoelCourtney to add example constraints to this branch Decision to be made: support non-records or updating docs? @JoelCourtney proposing to just update docs and allow non-records later. Let's start with only records and double-back for non-record support. |
db9d10f
to
4dc61a6
Compare
State of PR: The annotation processor worked without any extra work. It was actually so good at combining the scheduling / constraints workflows that the gradle task can't tell them apart, and the original
I haven't made the equivalent of the scheduler's |
|
@@ -3,7 +3,7 @@ package gov.nasa.ammos.aerie.procedural.scheduling | |||
import gov.nasa.jpl.aerie.merlin.protocol.types.SerializedValue | |||
import gov.nasa.jpl.aerie.merlin.protocol.types.ValueSchema | |||
|
|||
interface ProcedureMapper<T: Goal> { | |||
interface SchedulingProcedureMapper<T: Goal> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up: this rename will break existing uploaded procedural scheduling goals. I actually encountered the reverse of this, where I built a goal on this branch and tried to use it on the db support branch, only to get implementation not found
exception.
Description
Luke to fill out
Verification
Documentation
Future work