Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarcloud updates #273

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lylebarner
Copy link
Collaborator

This pull request incorporates changes required to allow openmct-mcws to allow for security scanning to be performed using SonarCloud

  • Create new GitHubAction that runs CoddeQL, pre-processes the results for import into SonarCloud, performs SonarCloud analysis and imports CodeQL results
  • Create new configuration file for SonarCloud analysis

Remaining actions required to enable analysis

  • Configured project on SonarCloud server (must be performed by organization owner)
  • Add SonarCloud access token to repository as SONAR_TOKEN

push:
branches: [ "main", "release/*" ]
pull_request:
branches: [ "main", "release/*" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


on:
push:
branches: [ "main", "release/*" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I just have one question. I see some scrub stuff included, and some scrub stuff commented out. Are we able to now just remove scrub entirely? Or, is there an interim phase while all the projects get onto SonarCloud?

@davetsay
Copy link
Collaborator

davetsay commented Feb 6, 2025

@lylebarner , also, a sonarcloud action is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants