-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to click on the affected URLs of a pattern and see which URLs have been affected #1038
Open
Kirandawadi
wants to merge
26
commits into
dev
Choose a base branch
from
1009-ability-to-click-on-the-affected-urls-of-a-pattern-and-see-which-urls-have-been-affected
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
933852b
Add 'Show Affected URLs' button and configure click handler
Kirandawadi b9d2385
Add necessary files for 'Affected URLs' page
Kirandawadi e89eaa1
Add DataTables features to the page
Kirandawadi 194929a
Affected URLs page for excluded patterns working properly
Kirandawadi b15410e
add view affected urls button to title patterns and document-type pat…
Kirandawadi 7a279fc
finalise the affected urls page for all the pattern types
Kirandawadi e736d2c
Refactor AffectedURLsListView into pattern-specific views
Kirandawadi 242d414
remove unnecessary comments and format code
Kirandawadi 32ed7f8
add integrity check to contents loaded from CDN
Kirandawadi 74e074a
remove unnecessary css declarations
Kirandawadi dad63b0
remove ordering functionality from second row of the datatable
Kirandawadi 11959fc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e68b50e
fix issues shown by flake8
Kirandawadi c545b8c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4205c1d
added include-pattern functionality; fixed candidate-urls-api (inclus…
Kirandawadi 42cdda0
remove 'add pattern' button from unnecessary pages
Kirandawadi 6b21213
add serializer class to affected urls functionalities
Kirandawadi 9d666b2
add datatables reload() feature to skip unnecessary ui modifications
Kirandawadi 6ec4943
fix ajax issues of datatable
Kirandawadi 37bdb7c
add 'include pattern' feature on right mouse click
Kirandawadi 1056ac9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 525e6a2
fix flake8 issues
Kirandawadi 597252c
add checks to see if include pattern already exists
Kirandawadi 4fd628b
fix 'exclude' column of 'Candidate URLs' page
Kirandawadi 1179641
fix 'affected urls' count
Kirandawadi 000153c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added include-pattern functionality; fixed candidate-urls-api (inclus…
…ion added)
- Loading branch information
commit 4205c1d9659f1308592a1de77740d976840bcb3a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are a lot of additional CSS rules on top of existing ones. Are these all required/used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored the affected_urls.css to only use required CSS declarations.