Skip to content

Commit

Permalink
Move CDK EOS ack to tox.ini
Browse files Browse the repository at this point in the history
  • Loading branch information
chuckwondo committed Oct 19, 2023
1 parent 3f07504 commit c4ca1fb
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 18 deletions.
19 changes: 1 addition & 18 deletions .github/workflows/mcp_dev_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,24 +71,7 @@ jobs:
jq -r <<<"$VARS_JSON" 'to_entries|map("\(.key)=\(.value)\u0000")[]'
)
- name: Deploy with tox
run: |
# NOTICES
#
# 19836 AWS CDK v1 End-of-Support June 1, 2023
#
# Overview: AWS CDK v1 is currently in maintenance mode. Support for AWS
# CDK v1 will end entirely on June 1, 2023. Migrate to AWS CDK
# v2 to continue to get the latest features and fixes!
#
# Affected versions: framework: 1.*, cli: 1.*
#
# More information at: https://github.com/aws/aws-cdk/issues/19836
#
#
# If you don’t want to see a notice anymore, use "cdk acknowledge <id>".
# For example, "cdk acknowledge 19836".
cdk acknowledge 19836
tox -v -e dev -r -- deploy --require-approval never
run: tox -v -e dev -r -- deploy --require-approval never
- name: Run DB setup
run: |
setupdb=$(aws cloudformation describe-stacks \
Expand Down
16 changes: 16 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,22 @@ passenv =
commands =
nodeenv --node=18.17.1 -p
npm install -g [email protected]
# NOTICES
#
# 19836 AWS CDK v1 End-of-Support June 1, 2023
#
# Overview: AWS CDK v1 is currently in maintenance mode. Support for AWS
# CDK v1 will end entirely on June 1, 2023. Migrate to AWS CDK
# v2 to continue to get the latest features and fixes!
#
# Affected versions: framework: 1.*, cli: 1.*
#
# More information at: https://github.com/aws/aws-cdk/issues/19836
#
#
# If you don’t want to see a notice anymore, use "cdk acknowledge <id>".
# For example, "cdk acknowledge 19836".
cdk acknowledge 19836
cdk --version

[testenv:dev]
Expand Down

0 comments on commit c4ca1fb

Please sign in to comment.