Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on new Exploration & Analysis and add dataset information #118

Merged
merged 9 commits into from
Aug 6, 2024

Conversation

j08lue
Copy link
Collaborator

@j08lue j08lue commented May 28, 2024

This adds dataset information summaries to be used in the updated Exploration & Analysis feature and turns on the feature.

  • Turned on feature
  • Added info for no2
  • Added info for all the other datasets
  • Verified that information is shown as expected

Information required

  1. For each dataset, add infoDescription to the front matter (see docs) - will show up here:

    image

  2. For each layer, add source, spatial extent, temporal resolution, and unit to an info block (see docs) - will show up here:

    image

Optional

You can also add a thumbnail for each layer that will be shown instead of the dataset thumbnail. See GHG Center exploration for examples of layer thumbnails made from rendered data instead of stock photo https://earth.gov/ghgcenter/exploration

Copy link

netlify bot commented May 28, 2024

Deploy Preview for earth-information-center ready!

Name Link
🔨 Latest commit 1b1f671
🔍 Latest deploy log https://app.netlify.com/sites/earth-information-center/deploys/66b28455f8e815000801fe3c
😎 Deploy Preview https://deploy-preview-118--earth-information-center.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@agurvich
Copy link
Collaborator

Alright y'all, I think I managed to get all the metadata in. I didn't realize that we already had it for each dataset under a Dataset Summary heading. I thought I was going to have to figure all of it out myself. I would've done this a lot sooner if I had been paying any attention. Major apologies it's sat this long.


infoDescription: |
::markdown
- **Temporal Extent:** 2012 - 2020
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is one too many indents here, the list is showing up incorrectly in the browser
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Good catch, I thought I looked at all of these... i think it's fixed now

@aboydnw
Copy link

aboydnw commented Jul 29, 2024

Thanks @agurvich. I made one small comment on the EPA dataset, otherwise looks good.

Two things, though:

  1. Do we need to bump the version of veda-ui to the latest? We are currently on 5.3.1 and I think we will be releasing 5.4.0 this week. Based on the layer selection, I am guessing this is behind.
  2. In the GHG Center Portal, EPA stakeholders did not want their data being analyzed against other datasets, so we forced the UI to only allow other EPA datasets to be selected when there is an EPA dataset selected. Should we enable the same logic here? Maybe it's not a concern for earth.gov because the datasets are more clearly disparate than on GHGC. Personally, I think that user experience we have on GHGC layer selection for EPA datasets is a little wonky so I'd say we only replicate it here if we have to.

@agurvich
Copy link
Collaborator

agurvich commented Aug 2, 2024

  1. Yes I agree, let's bump the veda-ui version number. More on slack, but there are some node version issues that look like we have to merge some commits in from the upstream veda-config.

  2. Let's not enable the same logic here. Our POCs at the other agencies are much more hands-off and haven't brought that up. I will touch base with EIC leadership and put on their radar, thanks for the heads-up!

@hanbyul-here hanbyul-here removed their request for review August 2, 2024 19:32
@aboydnw
Copy link

aboydnw commented Aug 6, 2024

Found an issue that we resolved in a previous PR, I thought this fix was included in 5.3.1 but maybe it was 5.4.0?

https://www.loom.com/share/4b370cc6f30a421a8175a985f62c7429?sid=a949790f-b802-4b6e-b273-02486730aeac

@aboydnw
Copy link

aboydnw commented Aug 6, 2024

Confirming that was 5.4.0 where we fixed this issue, see my comment here

@sandrahoang686 sandrahoang686 marked this pull request as ready for review August 6, 2024 19:25
@sandrahoang686 sandrahoang686 force-pushed the feat/dataset-info-for-ea branch from 2ac8476 to 1b1f671 Compare August 6, 2024 20:15
@sandrahoang686
Copy link

@agurvich @aboydnw I have updated this PR to the latest version of veda-ui v5.5.0 this could use validation from the both of you to make sure everything looks fine with the E&A page the rest of the changes in this PR. I've validated myself for the titiler update from v5.5.0 and its acting as it should which is requesting the new endpoint, failing (because titiler not yet in prod just yet) and then falling back to old endpoint
Screenshot 2024-08-06 at 4 22 11 PM

@agurvich
Copy link
Collaborator

agurvich commented Aug 6, 2024

Am I supposed to see a chart? If I hover over the area below the tooltip has the statistics in it but I thought there used to be lines:

image

@agurvich
Copy link
Collaborator

agurvich commented Aug 6, 2024

It's possible there's only one datapoint between the times I had selected so that's why there wasn't a line.

image

@aboydnw aboydnw self-requested a review August 6, 2024 21:00
Copy link

@aboydnw aboydnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's probably what happened @agurvich
I was able to generate time-series charts and everything seems functioning properly. It is interesting to test out the date picker updates with the data on earth.gov, though. Some of the crazy temporal ranges really pressure test our recent changes cc @dzole0311 @faustoperez

@agurvich agurvich merged commit d5e1848 into develop Aug 6, 2024
6 checks passed
@j08lue j08lue deleted the feat/dataset-info-for-ea branch August 7, 2024 08:48
@faustoperez
Copy link

Thanks @agurvich!

Regarding the single-point results, there's a related design ticket: NASA-IMPACT/veda-ui#961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants