-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on new Exploration & Analysis and add dataset information #118
Conversation
✅ Deploy Preview for earth-information-center ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Alright y'all, I think I managed to get all the metadata in. I didn't realize that we already had it for each dataset under a Dataset Summary heading. I thought I was going to have to figure all of it out myself. I would've done this a lot sooner if I had been paying any attention. Major apologies it's sat this long. |
|
||
infoDescription: | | ||
::markdown | ||
- **Temporal Extent:** 2012 - 2020 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agurvich. I made one small comment on the EPA dataset, otherwise looks good. Two things, though:
|
|
Found an issue that we resolved in a previous PR, I thought this fix was included in 5.3.1 but maybe it was 5.4.0? https://www.loom.com/share/4b370cc6f30a421a8175a985f62c7429?sid=a949790f-b802-4b6e-b273-02486730aeac |
Confirming that was 5.4.0 where we fixed this issue, see my comment here |
2ac8476
to
1b1f671
Compare
@agurvich @aboydnw I have updated this PR to the latest version of veda-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's probably what happened @agurvich
I was able to generate time-series charts and everything seems functioning properly. It is interesting to test out the date picker updates with the data on earth.gov, though. Some of the crazy temporal ranges really pressure test our recent changes cc @dzole0311 @faustoperez
Thanks @agurvich! Regarding the single-point results, there's a related design ticket: NASA-IMPACT/veda-ui#961 |
This adds dataset information summaries to be used in the updated Exploration & Analysis feature and turns on the feature.
no2
Information required
For each dataset, add
infoDescription
to the front matter (see docs) - will show up here:For each layer, add source, spatial extent, temporal resolution, and unit to an
info
block (see docs) - will show up here:Optional
You can also add a thumbnail for each layer that will be shown instead of the dataset thumbnail. See GHG Center exploration for examples of layer thumbnails made from rendered data instead of stock photo https://earth.gov/ghgcenter/exploration