Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for mono repo #111

Merged
merged 126 commits into from
Mar 8, 2024
Merged

Update for mono repo #111

merged 126 commits into from
Mar 8, 2024

Conversation

slesaad
Copy link
Member

@slesaad slesaad commented Feb 27, 2024 •
edited
Loading

Description

Changes to work with veda-deploy + others discovered along the way

Changes

Prerequisites

NASA-IMPACT/veda-auth#27

TODO

  • Permission to workflows lambda to read cognito secret

Abdel Marouane and others added 30 commits April 19, 2023 10:49
Deploy AIRFLOW to GHGC UAH
b4d5995
Deploy AIRFLOW to GHGC UAH
764658a
Deploy AIRFLOW to GHGC UAH
36a306f
Deploy AIRFLOW to GHGC UAH
dedae97
Deploy AIRFLOW to GHGC UAH
99d04be
Deploy AIRFLOW to GHGC UAH
d236065
Deploy AIRFLOW to GHGC UAH
1ddf415
Setup gitflow
01bf7b8
Provision RDS cluster
a813dff
@slesaad @Caden-Helbling
Update github actions and update bucket permissions (#2)
1bd28ea 
* Update GitHub workflows to use composite action
* Update buckets permissions
---------

Co-authored-by: Caden Helbling <[email protected]>
Merge branch 'dev' of https://github.com/NASA-IMPACT/ghgc-data-airflow …
9f200b1 
…into dev
Fix CICD
abbba97
Fix CICD
e8c9aeb
Fix CICD
504cb2e
Fix CICD
95fac5e
Fix CICD
6ea7a84
Fix CICD
2886922
Fix CICD
661f506
Fix CICD
50a8626
Fix CICD
bd34c37
Fix CICD
7a2ad14
Fix CICD and remove optional lines
78a649c
Fix CICD and remove optional lines with permission
6c4332f
Fix CICD and remove optional lines with vpc
66736aa
Fix CICD and remove optional lines with vpc and subnet
c8e4696
Fix CICD fix vpc and subnet
fc5a40e
Fix CICD fix variables
69a48ec
@slesaad
Fix optional var references in dags (#3)
c9e2afe
@slesaad
Fix containerOverrides expected datatype
e6c76ef
@slesaad
Uncomment subnets
e675b71
@slesaad slesaad marked this pull request as ready for review March 6, 2024 17:08
@slesaad slesaad requested review from smohiudd, anayeaye and ividito March 6, 2024 17:09
@smohiudd smohiudd requested a review from anayeaye March 7, 2024 16:15
@anayeaye
Copy link
Contributor

anayeaye commented Mar 8, 2024

I have added to the dev environment secrets used in the github dev workflow
VEDA_WORKFLOWS_CLIENT_SECRET_ID contains the id of the aws secrets manager containing the workflows client config
VEDA_PROGRAMMATIC_CLIENT_SECRET_ID contains the same for the programmatic client

anayeaye
anayeaye reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@anayeaye anayeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve once @slesaad's suggested change to terraform.tfvars.tpl are accepted

anayeaye
anayeaye reviewed Mar 8, 2024
View reviewed changes
.env.example Show resolved Hide resolved
@slesaad slesaad requested a review from anayeaye March 8, 2024 21:10
@slesaad slesaad merged commit 5b86b63 into dev Mar 8, 2024
3 checks passed
@slesaad slesaad mentioned this pull request Mar 13, 2024
Closed
@ividito ividito deleted the update-for-mono-repo branch May 29, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anayeaye anayeaye anayeaye approved these changes

@smohiudd smohiudd Awaiting requested review from smohiudd

@ividito ividito Awaiting requested review from ividito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@slesaad @smohiudd @anayeaye @Caden-Helbling @amarouane-ABDELHAK