Add optional transfer step to dataset DAG #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ividito
force-pushed
the
feat/transfer-in-dataset-dag
branch
from
3326f46 to
389aa9a
Compare
|
Rebased on dev to incorporate recent dataset DAG changes - needs testing + re-review. |
ividito
commented
Dec 9, 2024
ividito
commented
Dec 9, 2024
…control flow) - also modified sm2a makefile to run on ubuntu
ividito
force-pushed
the
feat/transfer-in-dataset-dag
branch
from
0d13062 to
ff49699
Compare
2 tasks
smohiudd
reviewed
Dec 19, 2024
| config = { | ||
| **payload, | ||
| **ti.dag_run.conf, | ||
| "origin_bucket": payload.get("bucket", ti.dag_run.conf.get("origin_bucket", "veda-data-store")), |
There was a problem hiding this comment.
should the origin here be veda-data-store-staging
There was a problem hiding this comment.
Not necessarily, doing it this way allows us to promote/transfer datasets where assets are stored in other buckets (I was thinking of some of the COVID dashboard collections here, but there could be others)
amarouane-ABDELHAK
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #256
If
transfer: trueis included in the dataset DAG payload, assets will be transferred to the production bucket prior to discovery and STAC item creation.dry_runis set to True by default - this should be changed before merging, but is better for testing.