This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Add ECCO dataset #219
Merged
Add ECCO dataset #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anayeaye
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
@ividito the start/end datetimes look good to me. I think it is correct that an item search for any date between 1992 and 2017 should hit this dataset.
The dashboard question is interesting, though, we have other datasets that cover a range like the facebook data that probably also display the latest date. I think the dataset title covers us in this case though, it makes it pretty clear that the data represent a change over time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #217
Not sure that I did the datetimes properly - the data represents a comparison between two dates, and I'm not sure how to properly reflect that. Right now, the dashboard shows this data as being from 1992, which isn't quite correct.