Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Add landcover 2001 2020 #229

Merged
merged 6 commits into from
Nov 29, 2022
Merged

Add landcover 2001 2020 #229

merged 6 commits into from
Nov 29, 2022

Conversation

vlulla
Copy link
Contributor

@vlulla vlulla commented Nov 10, 2022

Addresses #226

Copy link
Contributor

@anayeaye anayeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with small change to license id in collection

]
}
},
"license": "CC0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change: If you change this id to CC0-1.0 community tools like the browser will link out to the SPDX record https://spdx.org/licenses/CC0-1.0.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Done.

@vlulla vlulla changed the title Feature/add landcover 2001 2020 Add landcover 2001 2020 Nov 14, 2022
@vlulla
Copy link
Contributor Author

vlulla commented Nov 14, 2022

Made changes so that the netlify preview link at NASA-IMPACT/veda-config#134 works. Please ensure that you run the datetime summaries after ingesting the stac items.

@vlulla vlulla requested a review from anayeaye November 14, 2022 20:58
Copy link
Member

@slesaad slesaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The landcover maps are for specific instances of datetimes and setting
the `datetime_range` property breaks the netlify preview link.
Therefore, setting specific datetime for the item[s].
Setting start_datetime/end_datetime allows searching based on time range
too. So, using single_datetime was not a wise idea.
@moradology moradology force-pushed the feature/add-landcover-2001-2020 branch from b1f675c to 0333841 Compare November 22, 2022 16:52
@vlulla vlulla merged commit d28c156 into main Nov 29, 2022
@j08lue j08lue deleted the feature/add-landcover-2001-2020 branch December 1, 2022 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants