Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create pool only once and update timvt/tifeatures version #14

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

vincentsarago
Copy link
Collaborator

closes #13
closes #12

This PR does:

  • set DB max_conn to 1 in the CDK app
  • make sure to only run the pool creation once (and kept it cached)
  • update timvt and tifeatures version

@vincentsarago vincentsarago requested a review from j08lue December 14, 2022 23:06
Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @vincentsarago, keeping this codebase up-to-date with the latest development and bugfixes in tifeatures and timvt.

Feel free to remove the commented-out import as suggested below, unless there was a reason for keeping it in the code.

stack/app/handler.py Outdated Show resolved Hide resolved
@vincentsarago vincentsarago merged commit c7fd1cf into main Dec 15, 2022
@vincentsarago vincentsarago deleted the UpdateHandler branch December 15, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set db_max_conn_size to 1 in AWS Lambda env Create Db Pool only once
2 participants