App sporadically crashes

[j08lue]

The issue is a bit mysterious and transient at this point. The app crashes sometimes when a new page is loaded, e.g. via click on another menu item.

Forcing reload fixes it, as we do in

• Temporary fix of critical error encoutered during demos #680

But that degraded the user experience because the page reloads completely when switching between menu items.

Further investigation, e.g. via Sentry, is needed to get to the root of the issue

• Set up Sentry to understand the error better #681

Acceptance criteria

• Diagnosed and fixed the root cause of app crashes on page loads

[hanbyul-here]

The cases that I've collected so far:

• It happens when url is changed through react router.
• It happens when a user stays on the same page for a while ( doing nothing), and the3n tries to navigate to the other pages.

[nerik]

Currently trying to work our way back to what could be causing the problem in the GHG instance as this wasn't happening in veda-config.
US-GHG-Center/veda-config-ghg#179

[hanbyul-here]

I used the time after the demo to get to the root of this problem.

Crashes become noticeable after the introduction of Redirection

The problem seemed to be introduced after we put the logic for redirections using <Navigate /> component of React Router. Through React profiler, we could find that ShadowScrollbar was making way too many commits. (> 300 commits for scrolling on the page + clicking on the link on the nav.) We got rid of the redirection logic to resolve this issue. (The redirection logic was to prevent navigating to /explore page from the datasets that disable the dataset exploration/. which I can be a nice touch, but not really necessary.)

Noting that I am not sure what part of redirection exactly triggered the unnecessary amount of ShadowScrollbar.

There seem to be still problems with ShadowScrollbar

However, redirection might have amplified the problem, but not be the root of the problem. For example, ShadowScrollbar makes way too many commits when it is active on the page still. (just opening sub nav - which uses ShadowScrollbar - makes more than 100 commits.)

screen-recording-shadow.mov

I will go ahead and edit or get rid of ShadowScrollbar to prevent further breaks.