Create new raster paint layer module and factor out BaseTimeseriesPropos #1105
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for doing incredible work and reporting some issues @abarciauskas-bgse 🙇 To address your points,
Let's not worry about it now. We will likely remove
I had to think about this one. You are totally right that this should not happen. The intended experience is that the date picker should not allow you to select the date ranges outside of the temporal extent of the dataset. (ex. CMIP6 dataset has temporal extent of 
(The content below was edited because I realized my first response was not accurate! ) I wonder why you were able to select the date at all from the beginning. - Can you share the stac response and check the temporal extent is accurate? We're making a request to the STAC endpoint at the very beginning to retrieve the temporal extent of the dataset even before rendering each layer. And it seems like something went wrong/ something is missing there. If this is the case (that this error is not coming from the layer-related hooks) I think it would be better to address this issue separately, as long as it’s acceptable to have a suboptimal experience for these datasets for the moment 🙇 |
There was a problem hiding this comment.
LGTM 👍!
I would like to know more about the issues mentioned in the PR, that the request being made for tiles even when the selected date falls outside of the dataset temporal range. But if we are handling that issue separately anyway, that should not be a blocker.
|
@hanbyul-here |
## 🎉 Features - 🦗 ## 🚀 Improvements - Adding styles & Configurations for R3 #1104 - Create new raster paint layer module and factor out BaseTimeseriesProps #1105 - Remove PurgeCSS, configure USWDS to use only tablet breakpoints #1112 - Open an external link in a new tab #1116 - Expose USWDS card style #1119 ## 🐛 Fixes - Do not render exploration component unless urlAtom is on the right page #1106
## 🎉 Features - [E&A] Implement colormap configurability #1117 - [E&A] Feature flag colormap configurability #1147 - Add font md size as 20px for new Design System #1125 ## 🚀 Improvements - [E&A] Return default value of colormap along with other settings #1128 - Create new raster paint layer module and factor out BaseTimeseriesProps #1105 - Consolidate a place where to check linkProps #1121 #1160 - Expose Data Catalog and update child components to pass in routing/nav for library build #1096 #1159 - Set up eslint rule for no trailing spaces #1146 - Replace cmr-stac with titiler-cmr #1131 ## 🐛 Fixes - Update external link in top navigation target #1145 - Update PageHeader/Nav to not throw #1149 - [E&A] Fix to convert the time to usertzdate #1151 - Use sourceparams as it is when it is there #1148 - Fix compare label on block map #1153 - Discard the previous sourceExclusive value to fix the case when the datasets with different sourceExclusive can be selected together #1161 - Show the name of the selected filter on story hub #1161
Related Ticket: #1055
Description of Changes
Simply put, this PR is a small refactoring to create a basic
RasterPaintLayeravailable, which both ZarrTimeseries and CmrTimeseries use.ZarrPaintLayer. It seems appropriate then to renameZarrPaintLayertoRasterPaintLayerand put it in a separate file.Raster,Zarr, andCmrTimeseriesProposinto `BaseTimeseriesPropsNotes & Questions About Changes
Validation / Testing
I loaded the layers in the deploy preview, used the show/hide and time slider to make sure all that functionality was working as expected. I came across the issue described in (2) under Notes & Questions About Changes