-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for E&A #1229
Various fixes for E&A #1229
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
app/scripts/components/common/map/controls/aoi/custom-aoi-control.tsx
Outdated
Show resolved
Hide resolved
This PR handled the most of errors, except that the timelinedataset hydration through URL parameter not working. To simply describe the issue, we are using the dataLayers from Veda faux module (already compiled, and be used like a dependency) to reconcile the datasets from URL parameters. : https://github.com/NASA-IMPACT/veda-ui/blob/main/app/scripts/components/exploration/atoms/datasets.ts#L54 We would need to change how we approach static datasets for this part - I think one of the possible solution is to make the static datasets also an atom and hydrate it so it can be used inside of other atoms. Since this will require a bit more thoughts, I propose this PR to be merged first, and tackle this problem separately. I also wonder if we need to consolidate how other components pass static datasets as props to standardize the dataflow once the issue above is resolved. |
return this[this.length - 1]; | ||
}, | ||
set: undefined | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but probably it's better to define it once in some kind of a polyfills.ts
and use it / import it where needed.
Ran this locally with nextJs and |
Related Ticket: #1220
Description of Changes
This PR is WIP, opening in case it helps anybody. (That says, please don't spend time reviewing the changes in this PR yet, but it will be really helpful if you can validate that this branch can run with Next instance with stability.)
Notes & Questions About Changes
I've noticed E&A still doesn't run with stability in Next instance. I traced down all the possible errors that I can spot. That includes
Fixed in this PR
Not fixed in this PR yet
I put temporary work-arounds for unsolved problems to validate that those are the errors that can interrupt Next instance.
Validate & Test
Please test this branch with
test-branch
Next branch : https://github.com/developmentseed/next-veda-ui/tree/test-branch - It will still lack of some functionalities, but hopefully the e&a page doesn't return abrupt errors anymore.