AOI code cleanup #1248
Closed
AOI code cleanup #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… library, and get to render in nextJs instance
**Related Ticket:** #1156 ### Description of Changes - The main reason the data selector modal was not working is ~ again ~ link-related components error. I made it use `linkProperties` props. - I also moved `LinkProperties` type to `types/veda` ### Notes & Questions About Changes I will inline-comment ### Validation / Testing - Build the library from this branch - Use the built asset with this branch (of Next instance) : https://github.com/developmentseed/next-veda-ui/tree/data-selector-modal-test
**Related Ticket:** #1155 #1172 Related Next.js PR: developmentseed/next-veda-ui#7 ### Description of Changes - Fixed the map controls so that they work in the Next.js instance - Resolve issue with the Analyses Message display - Attempted to address the React mount error mentioned in #1172 ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing 1. Verify that the AOI controls and Analyses Message work as expected in both veda-ui and the Next.js instance 2. Verify that adding, deleting a single drawn area, or deleting all drawn areas works without issues 3. Ensure that analyses execute as expected
**Related Ticket:** #1158 ### Description of Changes The PR fixes `date-fns` imports which are breaking in Next.js, probably due to how Next.js handles ESM and CommonJS module imports. Next.js PR with explanation of the core issue: developmentseed/next-veda-ui#8 ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing _{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}_
**Related Ticket:** #1220 ### Description of Changes This PR is WIP, opening in case it helps anybody. (That says, please don't spend time reviewing the changes in this PR yet, but it will be really helpful if you can validate that this branch can run with Next instance with stability.) ### Notes & Questions About Changes I've noticed E&A still doesn't run with stability in Next instance. I traced down all the possible errors that I can spot. That includes #### Fixed in this PR - export useAtom hook for timelinedataset (to remove the possibility of more than one jotai instances) - LinkProperties problem - MapboxDraw not added to the map yet when its method is called - Date value that gets fed to atom is not valid - this was because our polyfill for Array.last was not getting exported #### Not fixed in this PR yet - TimelineDatasetAtom still depends on veda faux module datasets I put temporary work-arounds for unsolved problems to validate that those are the errors that can interrupt Next instance. ### Validate & Test Please test this branch with `test-branch` Next branch : https://github.com/developmentseed/next-veda-ui/tree/test-branch - It will still lack of some functionalities, but hopefully the e&a page doesn't return abrupt errors anymore.
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sandrahoang686
force-pushed
the
902-ea-breakout
branch
from
7771378 to
e130a6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1093
Description of Changes
While debugging the AOI for some of the bugs we are seeing, I did some cleanup around the code, just to streamline it a bit and make it easier to follow. I have some more thoughts in my local stash, but not yet committed. Since I am seeing more people touching AOI code, e.g. #1245, I want to open this as a draft for increased visibility.
Notes & Questions About Changes
It might not ever be merged, debugging is still in progress
Validation / Testing