feat: Implement page footer with USWDS components #1285
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
renamed old footer to PageFooterLegacy
I suppose the content will be included in the new footer component
Contributes to the feature branch #1285 Hej @snmln ! Thanks for setting up the feature branch and foundations for the new footer component! I renamed the old footer to PageFooterLegacy, that way we can use the regular import path for our new footer component. Also added a .env var that allows us to switch between old and new footer implementations easily. Campground Rule[^1]: While working on the feature flag, I addressed an unrelated lint warning within the files I made changes to. [^1]: Always leave the campground cleaner than you found it.
AliceR
changed the title
**Related Ticket:** _{link related ticket here}_
### Description of Changes
Creating slim footer.
- Establishing initial Front-end
- Creating footer object model in veda.config.js
- Setting up initial default.config.js
- Wiring up Config data flow
- Turning USWDS breakpoints on
TO DO's for this PR:
- Implement dynamic creation of links in footer component
AliceR
added
the
design system change
|
@faustoperez Can you take a look at the preview view here: https://deploy-preview-1285--veda-ui.netlify.app/ We have the front-end in place and are currently working through functionality. So this should be in a good spot for a design review. |
| import PageFooter from './index'; | ||
|
|
||
| const mockMainNavItems: NavItem[] = navItems.mainNavItems; | ||
| const mockSubNavItems: NavItem[] = navItems.subNavItems; |
There was a problem hiding this comment.
These mocks are mocking what looks to be used for the Header which includes dropdowns which footer doesn't worry about, we should probably explicity define the config for footer separately. And then test the dynamicness?
app/scripts/components/common/page-header/nav/create-dynamic-nav-menu-list.tsx
Show resolved
Hide resolved
…Components-Footer
Co-authored-by: Gjore Milevski <[email protected]>
There was a problem hiding this comment.
In the spirit of not wanting to drag this out any longer, this looks good to me. Related to dropdowns i've just updated this #1323 to address it since its not a blocker. There are issues with lint and test in the built which will need to be fixed before merging otherwise 👍🏼 and great work!
app/scripts/components/common/page-footer/return-to-top-button/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: sandrahoang686 <[email protected]>
|
@faustoperez Could you take a quick look at this and provide your review: https://deploy-preview-1285--veda-ui.netlify.app/ |
| } from '$components/common/uswds'; | ||
|
|
||
| interface PageFooterProps { | ||
| //use of NavItem is causing issues with TS and throwing erros in the . |
There was a problem hiding this comment.
| //use of NavItem is causing issues with TS and throwing erros in the . |
still an issue?
| linkProperties: LinkProperties; | ||
| } | ||
|
|
||
| //TODO: clean up PageFooterProps, Unexpected any. Specify a different interface. |
There was a problem hiding this comment.
| //TODO: clean up PageFooterProps, Unexpected any. Specify a different interface. |
Related Ticket: #1135
Description of Changes
TO DO:
Checkin with Fausto on progress.Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing
{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}