Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use markdown for the SiteAlert and Banner, remove HTML encoder dependency #1355

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

dzole0311
Copy link
Collaborator

Related Ticket: #1348

Description of Changes

  • Remove the HTML encoder dependency
  • Updated SiteAlert and Banner mocks to use markdown syntax, which is parsed via Parcel

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

  1. Tweak the content for the SiteAlert or the Banner in the the configuration file using markdown syntax for their content / text
  2. Restart your build process (yarn clean may be needed)
  3. Check that the changes are correctly displayed in the banner or site alert

@dzole0311 dzole0311 added the veda v2 VEDA Refactor Epic Work label Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 3e9ce51
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/677767f325a1190008e61bb9
😎 Deploy Preview https://deploy-preview-1355--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@hanbyul-here hanbyul-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇

@dzole0311 dzole0311 merged commit 72af78f into main Jan 7, 2025
10 checks passed
@dzole0311 dzole0311 deleted the refactor-adjust-content-to-markdown branch January 7, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants