Integrates STAC metadata request #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
danielfdsilva
commented
Sep 4, 2023
Comment on lines
38
to
49
| export interface TimelineDatasetData extends DatasetLayer { | ||
| isPeriodic: boolean; | ||
| timeDensity: TimeDensity; | ||
| domain: Date[]; | ||
| } | ||
|
|
||
| export interface TimelineDataset { | ||
| status: TimelineDatasetStatus; | ||
| data: any; | ||
| data: TimelineDatasetData; | ||
| error: any; | ||
| settings: { | ||
| // user defined settings like visibility, opacity |
There was a problem hiding this comment.
@nerik How much type narrowing should we be doing?
The isPeriodic and so on properties are only available when the status is success, otherwise they're undefined. We could do this type narrowing or set it to be possibly undefined. On one hand we have a more complicated type, but with undefined, we need to check every prop, instead of relying on status. Thoughts?
nerik
suggested changes
Sep 7, 2023
Comment on lines
69
to
114
| // END TimelineDatasetAnalysis type discriminants | ||
|
|
||
| export interface TimelineDatasetData extends DatasetLayer { | ||
| isPeriodic: boolean; | ||
| timeDensity: TimeDensity; | ||
| domain: Date[]; | ||
| } | ||
|
|
||
| // TimelineDataset type discriminants | ||
| export interface TimelineDatasetIdle { | ||
| status: TimelineDatasetStatus.IDLE; | ||
| data: DatasetLayer; | ||
| error: null; | ||
| settings: { | ||
| // user defined settings like visibility, opacity | ||
| isVisible?: boolean; | ||
| opacity?: number; | ||
| }; | ||
| analysis: TimelineDatasetAnalysisIdle; | ||
| } | ||
| export interface TimelineDatasetLoading { | ||
| status: TimelineDatasetStatus.LOADING; | ||
| data: DatasetLayer; | ||
| error: null; | ||
| settings: { | ||
| // user defined settings like visibility, opacity | ||
| isVisible?: boolean; | ||
| opacity?: number; | ||
| }; | ||
| analysis: TimelineDatasetAnalysisIdle; | ||
| } | ||
| export interface TimelineDatasetError { | ||
| status: TimelineDatasetStatus.ERROR; | ||
| data: DatasetLayer; | ||
| error: unknown; | ||
| settings: { | ||
| // user defined settings like visibility, opacity | ||
| isVisible?: boolean; | ||
| opacity?: number; | ||
| }; | ||
| analysis: TimelineDatasetAnalysisIdle; | ||
| } | ||
| export interface TimelineDatasetSuccess { | ||
| status: TimelineDatasetStatus.SUCCESS; | ||
| data: TimelineDatasetData; | ||
| error: null; |
There was a problem hiding this comment.
This can be simplified by:
- wrapping settings into a common Settings typr:
interface Settings {
isVisible?: boolean;
opacity?: number;
}
- extend a base type for all the unioned types:
interface TimelineDatasetBase {
data: DatasetLayer | TimelineDatasetData;
error: unknown | null;
settings: Settings;
analysis: TimelineDatasetAnalysisIdle | TimelineDatasetAnalysis;
}
|
@nerik whit which datasets did you notice this happening? |
|
@nerik now that we addresses the issues with the dataset domain, I think this is good to go. Can you have a final check? |
nerik
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When datasets are added to the timeline, metadata from STAC is requested and reconciles with local data