Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review updates #652

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Review updates #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7e24c99
Open hub in new tab
slesaad Sep 11, 2023
d77d174
Open dataset uasage links in a new tab
slesaad Sep 11, 2023
474e2f4
Add banner image to Development page
slesaad Sep 11, 2023
c34484b
Allow specifying banner image for About page
slesaad Sep 11, 2023
d50c04e
Add rel noopener to data usage links
slesaad Sep 12, 2023
5ddd5b3
Add rel noopener to hub link
slesaad Sep 12, 2023
1848435
Rename feedback button
danielfdsilva Sep 13, 2023
68f9a36
Update analysis nav button
danielfdsilva Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/scripts/components/about/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ function About() {
description={
aboutContent?.data.description || 'This is the default description'
}
coverSrc={aboutContent?.data.media?.src}
coverAlt={aboutContent?.data.media?.alt}
attributionAuthor={aboutContent?.data.media?.author?.name}
attributionUrl={aboutContent?.data.media?.author?.url}
/>
<ContentOverride with='aboutContent'>
<FoldProse>
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/components/common/google-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function GoogleForm() {
onClick={show}
style={{ color: 'white' }}
>
Feedback
Contact Us
</ButtonAsNavLink>
<Modal
id='modal'
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/components/common/notebook-connect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export function NotebookConnectModal(props: {
<DatasetUsages>
{datasetUsagesWithIcon.map((datasetUsage) => (
<li key={datasetUsage.url}>
<DatasetUsageLink href={datasetUsage.url}>
<DatasetUsageLink href={datasetUsage.url} target='_blank' rel='noopener'>
{IconByType[datasetUsage.type]}
<DatasetUsageLabel>
<h4>{datasetUsage.title}</h4>
Expand Down
5 changes: 3 additions & 2 deletions app/scripts/components/common/page-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ function PageHeader() {
to={ANALYSIS_PATH}
onClick={closeNavOnClick}
>
Analysis
Data Analysis
</GlobalMenuLink>
</li>
<li>
Expand All @@ -426,14 +426,15 @@ function PageHeader() {
<li>
<GlobalMenuLink
as='a'
target='_blank'
slesaad marked this conversation as resolved.
Show resolved Hide resolved
rel='noopener'
href={process.env.HUB_URL}
onClick={closeNavOnClick}
>
{process.env.HUB_NAME}
</GlobalMenuLink>
</li>
)}

</GlobalMenu>
</SectionsNavBlock>
<SectionsNavBlock>
Expand Down
4 changes: 4 additions & 0 deletions app/scripts/components/development/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ function Development() {
developmentContent?.data.description ||
'Visualization, Exploration, and Data Analysis (VEDA): Scalable and Interactive System for Science Data.'
}
coverSrc={developmentContent?.data.media?.src}
coverAlt={developmentContent?.data.media?.alt}
attributionAuthor={developmentContent?.data.media?.author?.name}
attributionUrl={developmentContent?.data.media?.author?.url}
/>

<ContentOverride with='developmentContent'>
Expand Down