GHG -> main #679

nerik · 2023-09-27T15:35:33Z

This PR, merged to `ghg`

Features

Analysis define
- New step-by-step layout and various UI tweaks
- Added sticky footer, moved submit and cancel buttons there
- Added an AoI preset for North America
- Datasets are not filtered from /collections metadata (spatial, temporal extent)
- Dates are now set by default to 2018 - 2022
- Replaced date presets with "2018 - 2022" and "last 10 years"
- Date selection not possible anymore before 01-01-1980
- Prevent users from selecting datasets when time range selected would mean fetching too many STAC items
Analysis results page: set a hardcoded limit on the number of items that can be requested as a failsafe mechanism for ☝️

Bugfixes

Removed logs in production (Turn off debug logs for UI US-GHG-Center/veda-config-ghg#152)
Temporary fix of critical error encoutered during demos (Temporary fix of critical error encoutered during demos #680)
Remove Shadow Scroll as a preventative method for (Remove shadow scroll #691)
Check only day level equity to validate dates (Check only day level equality for selected date #676)
Remove unneded attributes (Remove unneeded attribute #694)
BlockMap initial position error (Do not pass initial position at all if there is none #687)

Copy changes

Other PRs, merged to `main`

Added in veda UI but made configurable (so not affecting veda-config):

Bugfixes

…mit-stats

…series

for the function

This reverts commit 5c7a87d.

This reverts commit f9ae022.

Implements US-GHG-Center/veda-config-ghg#129

Handles issue in #682 (comment) While putting this fix, I noticed that `use-media-query` returns document body size, which differs from how CSS media query works. This results in a weird style in between 991 px ~ 1000 px. (screenshot attached, it is on ghg.center now) 👉 I didn't fix this problem, but I patched it with CSS. (Eventually, we would need to move to Container query instead of media query: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Container_Queries) ![Screen Shot 2023-10-04 at 3 01 10 PM](https://github.com/NASA-IMPACT/veda-ui/assets/4583806/215d0515-e4ff-4b42-b0b1-63a21506ad1c)

The date gets set back when I try to change the date for Plume datasets: https://ghg-demo.netlify.app/data-catalog/emit-ch4plume-v1/explore?projection=mercator%7C%7C&basemapid=satellite&datetime=2023-07-29T10%3A06%3A30.000Z This is because when a user inputs the date, the code checks if the date is in datetime list of the collection. Since Dashboard only provides daily level selection, selected datetime gets rounded down to the midnight of the selected date. Plume data datetimes don't have 00:00 timestamps, the selected date gets invalidated. I changed the code to check only day-level equality to align with dashboard capacity.

fix the bug where we pass `initialPosition` prop even when there is none defined by an editor.

Co-authored-by: Erik Escoffier <[email protected]>

Follow up of : #691 Fixing panel overflowing problem in https://deploy-preview-201--ghg-demo.netlify.app/data-catalog/epa-ch4emission-yeargrid-v2express/explore?projection=equirectangular%7C%7C&basemapid=light&datetime=2020-01-01T00%3A00%3A00.000Z Wow Scroll is hard. It will be ideal if we can find a way to stick the date widget and make only layers roll, but I am giving up here.. This change basically resurrects what `ShadowScroll` does for HTML and CSS sans some unnecessary elements for this case. I noticed that the window scroll sometimes pops up if you scroll very fast on the panel area. (Sorry, I cannot reproduce stably enough to grab a screen recording.) this error happens in production environment, too, so this PR doesn't necessarily introduce the error. But with the default (thicker) scroll, the error seems more noticeable.

Follow up of #692 Currently panel body is showing up scrolls even when not needed. This PR fixes the issue.

Handles one of warnings in #693

danielfdsilva

I pushed a commit with some css fixes. Mostly it rounds the button corners on the analysis page given that it was clashing with the remaining buttons on the same page. If the idea is to move to square buttons, then a overall change is required.

I'd like to us to understand if the ShadowScrollbar really is a source of problems and performance issues, given that it adds a shinier finish to the app.

Without it, the dropdowns look a bit like an afterthought.

Besides this I didn't see anything that would be GHG specific.

hanbyul-here · 2023-10-11T15:10:25Z

That is a good point about how the dropdown looks, so I added overscroll-behaviour: none to give a better look. I'd like to know the reason why ShadowScroll was making so many commits, too. But in any case, it is ideal not to depend on Javascript for scroll styling since it is prone to over-rendering.

danielfdsilva · 2023-10-11T16:59:58Z

@hanbyul-here My comment was related to styling, rather than behavior.
I'm not sure why it was causing so many commits just on open. That's definitely worth investigating.
On usage, it does some computation to display the shadows but that should not happen when it is opened.

Unfortunately there's no other way to style a scrolling element besides javascript. In this case we also want the shadow indicating that there's scrollable content which is not doable with css alone.
I think it is ok to degrade the visual experience a bit in favor of performance and not having errors, but I'd just lie us to be sure that this is actually causing problems.

hanbyul-here · 2023-10-11T19:34:11Z

As far as I can read, ShadowScrollbar attaches extra html to generate the shadow gradient in the background. If we think it is necessary, we can still make that effect with additional markup and styles, at least for the ones that will likely have scrolls. It won't be as sleek as the ShadowScroll, but there are some ways that we can style scrolls so they look like more thoughts went into them. (I made the style change, then I thought it was better to apply it more globally, so I reverted the style.)

But all in all, you agree that the visual degradation is acceptable, then can you clarify what changes you are requesting?

danielfdsilva · 2023-10-12T11:04:45Z

I just wanted us to understand if ShadowScrollbar really is the culprit behind the errors that we were seeing and why that was happening.
Given that its use gives the product a shinier finish I'd like us to be sure of any incompatibility before removing it completely.
I think that the extra elements that it adds and the calculations it performs are a perfectly acceptable thing to have - unless it really is breaking the app.

However I do understand that there may not be time to track down this error, and this (together with removing the redirects), seems to solve the problem. I'll leave this to your decision.

hanbyul-here · 2023-10-12T20:28:15Z

I will merge this, and still have a discussion about how we can improve style of scroll. nudging @faustoperez

hanbyul-here and others added 30 commits September 22, 2023 13:06

Thorw errors if too many statistics are requested

92f0574

Merge branch 'main' of github.com:NASA-IMPACT/veda-ui into feature/li…

db3fd08

…mit-stats

Return the guessed number of items based on collection metadata

441f059

Fixed types and variable names

42de6bc

Memoize datasets

c0f6b72

Check only day level equality

64a81aa

Updated analysis flow wording

f1e7171

Added sticky footer

9b24cd4

Prevent users from selecting datasets with too many data points

35bd7fa

Fixed number of data points estimate when isPeriodic=false using time…

2af6225

…series

Changed date presets

0a4a000

Replace reset icon

a67f413

Added north america preset

fd884ee

Fix getNumberOfItem logic when dataset is not periodic, add unit test

30ec70b

for the function

Style for 1,2,3 step

7f5c11f

Use fold for footer items

180447b

Align date selection tools, lint

d27f634

Select 2018-2022 date range by default

ee5a107

Hardcode min and max dates to 1980-01-01 through 2022-12-31

a40244d

Initialize the map with North America AoI

f9ae022

Correct month

5c7a87d

Revert "Correct month"

15a3227

This reverts commit 5c7a87d.

Revert "Initialize the map with North America AoI"

240017f

This reverts commit f9ae022.

Some design polish

9abac3b

Feature/analysis flow (#677)

e85073e

Implements US-GHG-Center/veda-config-ghg#129

Limit the datasets for analysis (#675)

31a9865

Fixed linter errors

a500bc9

Temporary fox of critical error encoutered during demos

5886af7

Remove logs in production

e00951a

Added disclaimer text on analysis results

54cf01e

hanbyul-here and others added 16 commits October 4, 2023 14:58

Remove shadow scroll

403b887

Lint

c47ca57

Lint, Put max height for mapoption container

808bba8

Add scrolly attribute to layer legend style

bd95167

Moving away from ShadowScroll because of this issue: #682 (comment)

0d567fa

Add styles to make panel scrollable

2d0a44d

Remove unneeded attribute

53ed47d

Do not pass initial position at all if there is none (#687)

f04141a

fix the bug where we pass `initialPosition` prop even when there is none defined by an editor.

Fix typo

cf8a812

Co-authored-by: Erik Escoffier <[email protected]>

Do not make scroll to appear when not needed

0971af0

Style fix for panel body (#695)

b3a3a75

Follow up of #692 Currently panel body is showing up scrolls even when not needed. This PR fixes the issue.

Remove unneeded attribute (#694)

fa4a261

Handles one of warnings in #693

Make buttons rounded

21c4186

danielfdsilva requested changes Oct 10, 2023

View reviewed changes

Add overscroll:none for dropdown and layer legend

7868db7

hanbyul-here added 2 commits October 11, 2023 14:32

Add scroll style

93fda36

Remove scroll style for now

63f6dc0

hanbyul-here marked this pull request as ready for review October 12, 2023 14:57

Lint

1c6cee6

danielfdsilva self-requested a review October 12, 2023 15:13

danielfdsilva approved these changes Oct 12, 2023

View reviewed changes

hanbyul-here merged commit a52e077 into main Oct 12, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GHG -> main #679

GHG -> main #679

nerik commented Sep 27, 2023 •

edited by hanbyul-here

Loading

danielfdsilva left a comment

hanbyul-here commented Oct 11, 2023

danielfdsilva commented Oct 11, 2023

hanbyul-here commented Oct 11, 2023 •

edited

Loading

danielfdsilva commented Oct 12, 2023

hanbyul-here commented Oct 12, 2023

GHG -> main #679

GHG -> main #679

Conversation

nerik commented Sep 27, 2023 • edited by hanbyul-here Loading

This PR, merged to ghg

Features

Bugfixes

Copy changes

Other PRs, merged to main

Added in veda UI but made configurable (so not affecting veda-config):

Bugfixes

danielfdsilva left a comment

Choose a reason for hiding this comment

hanbyul-here commented Oct 11, 2023

danielfdsilva commented Oct 11, 2023

hanbyul-here commented Oct 11, 2023 • edited Loading

danielfdsilva commented Oct 12, 2023

hanbyul-here commented Oct 12, 2023

nerik commented Sep 27, 2023 •

edited by hanbyul-here

Loading

This PR, merged to `ghg`

Other PRs, merged to `main`

hanbyul-here commented Oct 11, 2023 •

edited

Loading