Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix of critical error encoutered during demos #680

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Temporary fix of critical error encoutered during demos #680

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5886af7
Temporary fox of critical error encoutered during demos
amarouane-ABDELHAK Sep 27, 2023
586e5ad
Use as 'a'
hanbyul-here Sep 27, 2023
51219d8
Fix lint
hanbyul-here Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions app/scripts/components/common/page-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,9 @@ function PageHeader() {
if (!isMediumDown) setGlobalNavRevealed(false);
}, [isMediumDown]);

const closeNavOnClick = useCallback(() => setGlobalNavRevealed(false), []);
const closeNavOnClick = useCallback(() => {
setGlobalNavRevealed(false);
}, []);

return (
<PageHeaderSelf id={HEADER_ID}>
Expand Down Expand Up @@ -397,22 +399,28 @@ function PageHeader() {
<GlobalMenu>
<li>
<GlobalMenuLink
to={DATASETS_PATH}
as='a'
href={DATASETS_PATH}
onClick={closeNavOnClick}
>
Data Catalog
</GlobalMenuLink>
</li>
<li>
<GlobalMenuLink
to={ANALYSIS_PATH}
as='a'
href={ANALYSIS_PATH}
onClick={closeNavOnClick}
>
Data Analysis
</GlobalMenuLink>
</li>
<li>
<GlobalMenuLink to={STORIES_PATH} onClick={closeNavOnClick}>
<GlobalMenuLink
as='a'
href={STORIES_PATH}
onClick={closeNavOnClick}
>
{getString('stories').other}
</GlobalMenuLink>
</li>
Expand Down
Loading