WIP - Use new data type (+ simplify block map) #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
commented
May 31, 2024
| meta?: TimelineDatasetMeta; | ||
| } | ||
|
|
||
| export interface VizDatasetSUCCESS { |
There was a problem hiding this comment.
This is still a rough sketch of the new type only for visualization. But this is the general direction that I am trying to go.
There was a problem hiding this comment.
Thanks, this aligns with what I also imagined during our call on Friday!
hanbyul-here
force-pushed
the
969-s-explore-map
branch
from
899459c to
46b6777
Compare
hanbyul-here
force-pushed
the
969-s-explore-map
branch
from
4399937 to
f13ebe2
Compare
|
Closing this for https://github.com/NASA-IMPACT/veda-ui/pull/993/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #969, #967
Description of Changes
Opening this to share the current progress of work.
Notes & Questions About Changes
Validation / Testing