-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PR for seaice notebook. #138
Conversation
I apologize for all of the commit / push nonsense. I was trying to figure out the pre-commit stuff. I finally fixed it all! |
I guess I still need some help here with the PR Tasks. |
Might be a little late now, but you can have |
I tried to install and run pre-commit, but I couldn't figure it out. Is it just pip install pre-commit? I did this and it still did not find the command. |
That's meant to be a "pass if all the checklist items are complete, fail if something still needs to be done" but it isn't working quite right -- @TeaganKing is talking to the NCAR organization admin team to see about installing a better tool for that check. We can merge this in even if that check is failing, the |
It should already be installed in |
Ok. So, I had not updated the cupid-dev environment in many months. We should probably have something in the workflow about this if we don't already. |
See #139 -- this should be implemented shortly. |
I am waiting on this until the latest CUPiD is up to date. |
All Submissions:
pre-commit
check)?New Feature Submissions:
Changes to Core Features:
I have made several updates to the sea ice notebook here.