Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect limiter in FULL_DEPTH_KHTR_MIN implementation #318

Merged

Commits on Oct 25, 2024

  1. Fix incorrect limiter in FULL_DEPTH_KHTR_MIN implementation

    The initial implementation of FULL_DEPTH_KHTR_MIN was incorrect.
    CS%KhTr_min [L2 T-1] was used to limit Coef_y/Coef_x [L2 or H L2]
    and this was wrong. Here is the (wrong) example at v-points:
    
    Coef_y = max(Coef_y, KhTr_min)
    
    This patch fixes this bug by introducing a local limiting value
    for Coef_x and Coef_y, Coef_min [L2 or H L2]:
    
    Coef_min = I_numitts * dt * (KhTr_min*(dx_Cv*IdyCv))
    
    The correct limit is then:
    
    Coef_y = max(Coef_y, Coef_min)
    gustavo-marques committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    fc0cf0f View commit details
    Browse the repository at this point in the history