Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saturation_vapor_pressure #154

Merged
merged 7 commits into from
Dec 6, 2024
Merged

saturation_vapor_pressure #154

merged 7 commits into from
Dec 6, 2024

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Nov 22, 2024 •
edited
Loading

PR Summary

Covers satvpr_temp_fao56 to compute the saturation vapor pressure using temperature

Related Tickets & Documents

Closes #153

PR Checklist

General

  • PR includes a summary of changes
  • Link relevant issues, make one if none exist
  • If adding a new page, select which type:
    • NCL Entry
    • Receipt
  • Clear Output

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

Meowdy! See your PR preview:
🔍 Git commit SHA: c1e1c5f
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/154

@cyschneck cyschneck self-assigned this Nov 25, 2024
@cyschneck cyschneck added ncl receipt Receipt files are small files with little to no narrative content ncl entry NCL entries are pages that explain specifically how to achieve something that was possible in NCL labels Nov 25, 2024
@cyschneck cyschneck marked this pull request as ready for review November 25, 2024 23:11
kafitzgerald
kafitzgerald approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

anissa111
anissa111 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reminded that we had a conversation a while back about setting standard relative tolerances for applications that I do eventually want to get back to, but that standardization is outside the scope of this PR.

Thanks Cora!

@cyschneck
Copy link
Contributor Author

I am reminded that we had a conversation a while back about setting standard relative tolerances for applications that I do eventually want to get back to, but that standardization is outside the scope of this PR.

Thanks Cora!

Agreed! It would be a good part of the receipts refresh and standardization

@cyschneck cyschneck merged commit 796b294 into NCAR:main Dec 6, 2024
3 checks passed
@cyschneck cyschneck deleted the satvpr_temp_fao56 branch December 6, 2024 21:29
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
@cyschneck @github-actions
Delete preview for pull request #154
cc3d40f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kafitzgerald kafitzgerald kafitzgerald approved these changes

@anissa111 anissa111 anissa111 approved these changes

@jukent jukent Awaiting requested review from jukent

Assignees

@cyschneck cyschneck

Labels
ncl entry NCL entries are pages that explain specifically how to achieve something that was possible in NCL ncl receipt Receipt files are small files with little to no narrative content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meteorology - saturation_vapor_pressure
3 participants
@cyschneck @kafitzgerald @anissa111