-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel_35 to use data from geocat.datafiiles instead of creating on the fly with generate_2d_array #559
Conversation
Should this get updated as well? |
Otherwise, this looks good! |
No that was added there- thrown into scratch in case we need it again for something similar. No update needed |
Oh, I see. That was the original code that this removed and not the code specifically to create the netCDF files themselves (that are now being used). Sorry for the confusion on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Makes this so much more clear!
It was the data saving step I had to adjust which isn't represented, but I think that's fine. |
Closes #558
Currently doesn't like how the data is formatted. Need to figure that out. If my datafiles need to be regenerated the code is here: https://github.com/NCAR/geocat-scratch/blob/main/geocat-examples/generate_2d_array.py