Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel_35 to use data from geocat.datafiiles instead of creating on the fly with generate_2d_array #559

Merged
merged 12 commits into from
Jan 10, 2024

Conversation

jukent
Copy link
Collaborator

@jukent jukent commented Nov 9, 2023

Closes #558

Currently doesn't like how the data is formatted. Need to figure that out. If my datafiles need to be regenerated the code is here: https://github.com/NCAR/geocat-scratch/blob/main/geocat-examples/generate_2d_array.py

@jukent jukent marked this pull request as ready for review January 10, 2024 16:54
@jukent jukent requested a review from kafitzgerald January 10, 2024 16:54
@kafitzgerald
Copy link
Collaborator

Currently doesn't like how the data is formatted. Need to figure that out. If my datafiles need to be regenerated the code is here: https://github.com/NCAR/geocat-scratch/blob/main/geocat-examples/generate_2d_array.py

Should this get updated as well?

@kafitzgerald
Copy link
Collaborator

Currently doesn't like how the data is formatted. Need to figure that out. If my datafiles need to be regenerated the code is here: https://github.com/NCAR/geocat-scratch/blob/main/geocat-examples/generate_2d_array.py

Should this get updated as well?

Otherwise, this looks good!

@jukent
Copy link
Collaborator Author

jukent commented Jan 10, 2024

No that was added there- thrown into scratch in case we need it again for something similar. No update needed

@kafitzgerald
Copy link
Collaborator

Oh, I see. That was the original code that this removed and not the code specifically to create the netCDF files themselves (that are now being used).

Sorry for the confusion on that.

Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Makes this so much more clear!

@jukent jukent merged commit f783a15 into NCAR:main Jan 10, 2024
7 checks passed
@jukent
Copy link
Collaborator Author

jukent commented Jan 10, 2024

It was the data saving step I had to adjust which isn't represented, but I think that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change panel_35 to load data from geocat-datafiles
2 participants