Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Xarray version w/ bug #628

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

kafitzgerald
Copy link
Collaborator

@kafitzgerald kafitzgerald commented Dec 7, 2024

Exclude xarray version with the seaborn import bug mentioned in #627. Since there's already a fix, the next release should be fine (i.e. no need to further constrain the version).

Closes #627

@kafitzgerald kafitzgerald marked this pull request as ready for review December 7, 2024 00:14
Copy link
Collaborator

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we open an issue timed to remind us of the Xarray release?

@kafitzgerald
Copy link
Collaborator Author

Should we open an issue timed to remind us of the Xarray release?

Given the Xarray versioning scheme, I think we can/should just leave this as is. It'll prevent folks from installing the broken version, but newer versions should install fine.

@kafitzgerald kafitzgerald merged commit 8f08732 into NCAR:main Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failures following Xarray 2024.11.0
2 participants