Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts to compare LASSO LES and CCPP SCM data #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evankalina
Copy link

@evankalina evankalina commented Nov 16, 2021

@bluefinweiwei and @ligiabernardet, this PR adds scripts to compare LASSO LES data subsets from Wayne Angevine (CIRES at NOAA/CSL) to output from CCPP SCM runs of the 2018 LASSO cases. For a full explanation of the capabilities, please see lasso-scm_comp/README_wa_subsets.txt.

Copy link
Collaborator

@ligiabernardet ligiabernardet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. I only reviewed the README file - everything was well explained. @bluefinweiwei is now reviewing some other aspects of the PR.

@bluefinweiwei bluefinweiwei self-assigned this Nov 29, 2021
Copy link
Collaborator

@bluefinweiwei bluefinweiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @evankalina Thanks so so much for the great effort and the very detailed instructions. All look very nice to me and I've only left some minor comments. I have to say I should have more carefully reviewed Dan's scripts but I didn't due to multiple reasons (sorry about that!)... Anyway, I think we can merge this PR very soon.

qtend_scm = f_cases[:]->q_tend_profile_SCM
wspdtend_scm = f_cases[:]->wspd_tend_profile_SCM

; Calculate the lapse rate of potential temperature.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the calculation is based on theta not actual temperature (T), we probably would want to call it static stability criteria for dry air but not lapse rate (or gamma).

; creates kinks because the derivative of a line is a
; constant value. Need to preserve the original structure
; within the surface layer, which requires some tricks.
gamma_scm_smoo=runave(gamma_scm,8,0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why applying 8-point (but not others) moving average? For removing kinks?

; within the surface layer, which requires some tricks.
gamma_scm_smoo=runave(gamma_scm,8,0)
gamma_scm_smoo(:,:,1)=gamma_scm(:,:,1)
gamma_scm_smoo(:,:,2)=dim_avg_n(gamma_scm(:,:,1:3),2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3-point moving average applied to 3rd level, correct?

gamma_scm_smoo=runave(gamma_scm,8,0)
gamma_scm_smoo(:,:,1)=gamma_scm(:,:,1)
gamma_scm_smoo(:,:,2)=dim_avg_n(gamma_scm(:,:,1:3),2)
gamma_scm_smoo(:,:,3)=dim_avg_n(gamma_scm(:,:,1:5),2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5-point moving average applied to 4th level, correct?

; constant value. Need to preserve the original structure
; within the surface layer, which requires some tricks.
gamma_scm_smoo=runave(gamma_scm,8,0)
gamma_scm_smoo(:,:,1)=gamma_scm(:,:,1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have gamma_scm_smoo(:,:,0)?

hgtscm3d = conform(ttendctl_nat_Khr,hgtscm_m,(/0,1/))

; SCM specific humidity to water vapor mixing ratio.
rvctl_nat_kgkg = qvctl_nat_kgkg/(1.-qvctl_nat_kgkg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat and accurate (as I usually just assume SH = Qv...).


; Finding the density of air using the ideal gas law to convert surface tau
; (wind stress) to surface winds
rhoscm = psfcscm / (tmpscm_K(:,0) * R_dry)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering moisture, virtual temperature (Tv) should be used?

case_files = True

; Directory to write results.
diro = "/work/noaa/ufs-phys/ekalina/lasso-les/comparison_data/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now I see what this directory is all about.

Evan Kalina.

* LASSO_SCM_plot_composite.ncl - Generate composites of the LASSO LES and
CCPP SCM results from all of the cases. Not run by LASSO_wrapper.ncl.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "Not run by LASSO_wrapper.ncl." mean? Why highlight this?

* LASSO_SCM_plot_composite.ncl - Generate composites of the LASSO LES and
CCPP SCM results from all of the cases. Not run by LASSO_wrapper.ncl.
* LASSO_SCM_multicase_comp.ncl - Plot the results from each individual case
on the same plot. The computation of the potential temperature lapse rate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, not sure about the term "potential temperature lapse rate" here... do we really have such a thing, or it's simply the static stability criteria for dry air?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants