Leosphere format update #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e res_id is now an int attribute, not a string attribute. Catch exception of trying to convert an int to a string, and instead get its value as an int and then convert to string.
…ing to combine RHI on non RHI files, since file processing still works apart from combining RHI, make wording on multiple sweeps error a little clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ISS Leosphere lidar got a software update recently that slightly changed the format of its netCDF (supposedly CFRadial but not quite) files. The specific difference that matters to RadxConvert is that the type of the res_id attribute in the sweep group has changed.
In earlier files:
:res_id = "3" ;(string attribute)But now it's:
:res_id = 7 ;(int attribute)RadxConvert was failing because it was attempting to access res_id as a string attribute when it wasn't. I added catching that netcdf exception and instead trying to read the attribute as an int, then converting to string, and now RadxConvert successfully generates CFRadial files.