Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TUV-x photolysis rate constant and heating rate ordering access #235

Merged
merged 3 commits into from
Nov 1, 2024
Merged

TUV-x photolysis rate constant and heating rate ordering access #235

merged 3 commits into from
Nov 1, 2024

Conversation

mattldawson
Copy link
Collaborator

Adds the ability to access the ordering of photolysis rate constants and heating rates by name through the MUSICA API in C and Fortran.

boulderdaze
boulderdaze requested changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a couple of minor comments and questions.

src/tuvx/interface_util.cpp Outdated Show resolved Hide resolved
src/tuvx/interface_util.hpp Outdated Show resolved Hide resolved
src/tuvx/interface_grid.F90 Outdated Show resolved Hide resolved
src/tuvx/interface_grid_map.F90 Outdated Show resolved Hide resolved
src/tuvx/interface_profile.F90 Outdated Show resolved Hide resolved
src/tuvx/interface_profile_map.F90 Outdated Show resolved Hide resolved
src/tuvx/interface_radiator_map.F90 Outdated Show resolved Hide resolved
src/tuvx/interface_util.F90 Outdated Show resolved Hide resolved
src/tuvx/interface.F90 Outdated Show resolved Hide resolved
boulderdaze
boulderdaze approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the comments!

@mattldawson mattldawson merged commit ff9f8de into main Nov 1, 2024
66 checks passed
@mattldawson mattldawson deleted the develop-add-tuvx-mapping branch November 1, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boulderdaze boulderdaze boulderdaze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattldawson @boulderdaze