Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access species properties through API #86

Merged
merged 13 commits into from
Apr 11, 2024
Merged

Conversation

mattldawson
Copy link
Collaborator

Adds the ability to query for species properties through the API. Also modifies some Dockerfiles and GH Actions for more automated testing on development branches

closes #62

@mattldawson mattldawson marked this pull request as draft April 10, 2024 14:18
@mattldawson mattldawson marked this pull request as ready for review April 10, 2024 18:07
@mattldawson
Copy link
Collaborator Author

I think everything is passing now.

I bypassed one of the tests when using the ClangCL toolset on Windows because it didn't seem like ASSERT_THROW() wasn't working, but I'm not sure what the real problem is.

The fortran tests that are failing should pass once this is merged in to main (I think). I tested them locally and they worked when using the musica-c library code from by dev branch

Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattldawson mattldawson merged commit 477af65 into main Apr 11, 2024
34 of 40 checks passed
@mattldawson mattldawson deleted the develop-62-custom-props branch April 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communicate custom configuration properties
3 participants