Adding pFUnit Support for Unit Testing in obs2ioda #23
Conversation
|
|
…tests. As of now, there are no unit tests but that will change in the future. Also updated installation section of The README to include instructions on how to install pFUnit and build obs2ioda with pFUnit support.
The command now is executed with bash -c '<prev command>' to make it possible to run from any shell, given the system has bash installed.
Removed seemingly hard requirement that build directories have to be named 'build' in the install instructions.
amstokely
force-pushed
the
feature/pfunit
branch
from
c4f1399 to
2b62978
Compare
|
Is the code in |
I meant to include these files in a later PR. Thanks for pointing this out!. |
| If you have an environment preconfigured for `mpas-jedi`, simply source that environment prior to building `obs2ioda`. | ||
| Prior to building `obs2ioda`, ensure that you have installed the following libraries: | ||
|
|
||
| - **CMake**: Required (version 3.20 or higher). |
There was a problem hiding this comment.
I think this should now read 3.12.
| @@ -54,9 +73,34 @@ To install the NCEP BUFR library, follow these steps: | |||
| ``` | |||
| 5. To locate the NCEP BUFR library, run: | |||
| ```bash | |||
| find . -name *libbufr* | |||
| bash -c "find . -name *libbufr*" | |||
There was a problem hiding this comment.
Is there a specific reason this find command needs to be run in the bash shell?
This PR introduces support for using pFUnit to write unit tests in the
obs2iodaproject, a key step in refactoring legacy Fortran code. Unit testing is essential for verifying that code changes do not introduce subtle, breaking issues. Given the current lack of a unit testing framework inobs2ioda, maintaining code quality and making major changes safely have been challenging.This PR addresses these issues by:
The installation instructions have been updated with guidance on installing pFUnit and enabling testing during the CMake build process.
By establishing a unit testing framework, this PR sets the foundation for future improvements and enhances the reliability of code refactoring efforts.
**Closing this PR due to compilation issues with
pFUnitand thenvhpccompilers (pFUnit Issue 476)