(#107) Update to modern analytics. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanpizzillo
previously requested changes
Nov 18, 2024
There was a problem hiding this comment.
@blairlearn can you please check if you still need jquery? It is a really old version in use and should either be updated or removed. It looked like the jQuery was mostly for the analytics functions.
Also please remove the JS from the project if it is no longer being loaded. No need to confuse yourself in 6 months.
blairlearn
force-pushed
the
ticket/107-analytics
branch
2 times, most recently
from
8ebad9a to
a71e47d
Compare
This will need to be a task for three months after the release. Otherwise, any pre-existing, not-yet-expired pages in the system will break. |
- Leave BasicCTSPrintPage.js and rewrite rules for legacy JS files in order to support unexpired legacy pages. These will need to be removed at a later date. - Remove reference to JQuery (used for old analytics support). - Remove legacy print-legacy.txt Closes #107
blairlearn
force-pushed
the
ticket/107-analytics
branch
from
a71e47d to
85b6eeb
Compare
|
Changes looking good in testing. Some environment related hiccups, but we will re-review as this moves closer to production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107