(#112, #114) Save search metadata as a separate document. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blairlearn
force-pushed
the
ticket/112-metadata
branch
from
38814ed to
05eefdc
Compare
blairlearn
force-pushed
the
ticket/112-metadata
branch
from
05eefdc to
49c6f9e
Compare
blairlearn
changed the title
blairlearn
force-pushed
the
ticket/112-metadata
branch
from
49c6f9e to
11f3a39
Compare
bryanpizzillo
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
I am approving, but monitoring the logging for this application will be REALLY important to determine how often the 2 files don't get saved together. There should also be some AWS response codes that could allow a retry of one of the failed files being uploaded.
I assume a failure of one of the files will end up being a failure from the API, so a user would not be sent a bad cache item. But it will be good to know the frequency and have access to these logs.
Maybe OpenTelementry is something that should be looked into to capture this info in DataDog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112
Closes #114