-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#147) Update Node, Webpack, Misc security updates #155
Conversation
Viewing Information |
b2621e8
to
2bb37cf
Compare
1fca841
to
7466e80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works correctly on react-app-dev!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing - a coverage output file got into this PR.
output.test.log
Outdated
@@ -0,0 +1,181 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be excluded or removed.
Updates node to 20, webpack to v8 and addresses security updates ``` nvm install 20 nvm use 20 ``` * Updates LTS in `.nvmrc` `npm install webpack@latest --save-dev` - Updates webpack config to address CRA CommonJS bug affecting axios/nock/jest combo facebook/create-react-app#11889 (comment) - Updater syntax change for IgnorePlugin in webpack config - Misc webpack config changes following migration guide: https://webpack.js.org/migrate/5/ - Moves jest config out of package.json into own config - Adds axios to transformIgnoreModules `npm audit fix --force`
7466e80
to
3fae8d7
Compare
Whenever you get a moment the change is ready for review, @bryanpizzillo |
Description
Updates node, webpack, and other packages to enable security changes. Upgrades dependencies to webpack 5 compatible versions.
Notable package upgrades
Replaces deprecated (Since March 2020)
babel-eslint
with@babel/eslint-parser
Replace deprecated eslint-loader with eslint-webpack-plugin
In addition, adds the following dev dependencies
(#147) Upgrade to Node 18, Webpack 5, npm audit fixes
Description
Updates node, webpack, and other packages to enable security changes. Upgrades dependencies to webpack 5 compatible versions.
Notable package upgrades
Replaces deprecated (Since March 2020)
babel-eslint
with@babel/eslint-parser
Replace deprecated eslint-loader with eslint-webpack-plugin
In addition, adds the following dev dependencies
Updates node to 30
File(s):
.nvmrc
Extracts jest config to separate file
File(s):
.package.json
jest.config.js
package.json
Updates Webpack to 5
Installl latest webpack,
Updates webpack config to address CRA CommonJS import bug affecting axios/nock/jest combo
File(s):
/config/paths.js
webpack.config.js
jest.config.js
Adds support for cjs/mjs extension
require
a submodule of a package (i.e.my-package/sub-module
) returns a string instead of the module facebook/create-react-app#11889 (comment)jest.config.js
Updates
buildAxiosRequest.test.js
to set the addapter type to httpApp.test.js
to remove the following:Updates webpack config for breaking changes from v4 -> v5
Misc webpack config changes following migration guide: https://webpack.js.org/migrate/5/
File(s):
webpack.config.js
babel.config.js
.eslintrc.js
Updates syntax change for IgnorePlugin in webpack config
ManifestPlugin
to the following:js const { WebpackManifestPlugin } = require('webpack-manifest-plugin');
Updates the webpack hashing function from the insecure
md4
toxxhash64
Resolves the following error:
Adds absoluteRuntime key to
babel.config.js
Replaces deprecated
babe-eslint
with@babel/eslint-parser
Replaces
eslint-loader
with eslint-webpack-plugin in webpack configUpdates loader syntax. Usage of loader notation 'style-loader!css-loader' is deprecated and replaced with
[{loader: ‘style-loader’}, {loader: ‘css-loader’}]
Security Fixes
Linter fixes
Closes #147